Disable precise compiler invocations for playgrounds

Author: kastiglione

lldb/source/Plugins/ExpressionParser/Swift/SwiftUserExpression.cpp

@@ -733,7 +733,8 @@ exe_scope = exe_ctx.GetBestExecutionContextScope();
 
   const SymbolContext *sc =
       &frame->GetSymbolContext(lldb::eSymbolContextFunction);
-  auto *swift_ast_ctx = m_swift_scratch_ctx->get()->GetSwiftASTContext(sc);
+  auto *swift_ast_ctx =
+      m_swift_scratch_ctx->get()->GetSwiftASTContext(sc, true);
   m_swift_ast_ctx =
       llvm::dyn_cast_or_null<SwiftASTContextForExpressions>(swift_ast_ctx);
 

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.h

@@ -223,8 +223,10 @@ class SwiftASTContext : public TypeSystemSwift {
 
   bool SupportsLanguage(lldb::LanguageType language) override;
 
-  SwiftASTContext *GetSwiftASTContext(const SymbolContext *sc) const override {
-    return GetTypeSystemSwiftTypeRef().GetSwiftASTContext(sc);
+  SwiftASTContext *
+  GetSwiftASTContext(const SymbolContext *sc,
+                     bool for_playground = false) const override {
+    return GetTypeSystemSwiftTypeRef().GetSwiftASTContext(sc, for_playground);
   }
 
   TypeSystemSwiftTypeRef &GetTypeSystemSwiftTypeRef() override {

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwift.h

@@ -115,7 +115,9 @@ class TypeSystemSwift : public TypeSystem {
 
   const std::string &GetDescription() const { return m_description; }
   static LanguageSet GetSupportedLanguagesForTypes();
-  virtual SwiftASTContext *GetSwiftASTContext(const SymbolContext *sc) const = 0;
+  virtual SwiftASTContext *
+  GetSwiftASTContext(const SymbolContext *sc,
+                     bool for_playground = false) const = 0;
   virtual TypeSystemSwiftTypeRef &GetTypeSystemSwiftTypeRef() = 0;
   virtual const TypeSystemSwiftTypeRef &GetTypeSystemSwiftTypeRef() const = 0;
   virtual void SetTriple(const llvm::Triple triple) = 0;

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp

@@ -1818,7 +1818,8 @@ SwiftASTContext *TypeSystemSwiftTypeRef::GetSwiftASTContextFromExecutionContext(
 }
 
 SwiftASTContext *
-TypeSystemSwiftTypeRef::GetSwiftASTContext(const SymbolContext *sc) const {
+TypeSystemSwiftTypeRef::GetSwiftASTContext(const SymbolContext *sc,
+                                           bool for_playground) const {
   std::lock_guard<std::mutex> guard(m_swift_ast_context_lock);
   // There is only one per-module context.
   const char *key = nullptr;
@@ -1843,12 +1844,16 @@ TypeSystemSwiftTypeRef::GetSwiftASTContext(const SymbolContext *sc) const {
 }
 
 SwiftASTContext *TypeSystemSwiftTypeRefForExpressions::GetSwiftASTContext(
-    const SymbolContext *sc) const {
+    const SymbolContext *sc, bool for_playground) const {
   bool precise = false;
   // Compute the cache key.
   const char *key = nullptr;
-  if (sc && ModuleList::GetGlobalModuleListProperties()
-                .GetUseSwiftPreciseCompilerInvocation()) {
+  // Disable precise compiler invocations for playground expression evaluation.
+  // For playgrounds, the target triple should be used for expression
+  // evaluation, not the current module.
+  if (!for_playground && sc &&
+      ModuleList::GetGlobalModuleListProperties()
+          .GetUseSwiftPreciseCompilerInvocation()) {
     ConstString module = GetSwiftModuleFor(sc);
     key = module.GetCString();
     precise = true;

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.h

@@ -68,7 +68,9 @@ class TypeSystemSwiftTypeRef : public TypeSystemSwift {
   ~TypeSystemSwiftTypeRef();
   TypeSystemSwiftTypeRef(Module &module);
   /// Get the corresponding SwiftASTContext, and create one if necessary.
-  SwiftASTContext *GetSwiftASTContext(const SymbolContext *sc) const override;
+  SwiftASTContext *
+  GetSwiftASTContext(const SymbolContext *sc,
+                     bool for_playground = false) const override;
   /// Convenience helpers.
   SwiftASTContext *
   GetSwiftASTContextFromExecutionScope(ExecutionContextScope *exe_scope) const;
@@ -529,7 +531,9 @@ class TypeSystemSwiftTypeRefForExpressions : public TypeSystemSwiftTypeRef {
   TypeSystemSwiftTypeRefForExpressions(lldb::LanguageType language,
                                        Target &target, Module &module);
 
-  SwiftASTContext *GetSwiftASTContext(const SymbolContext *sc) const override;
+  SwiftASTContext *
+  GetSwiftASTContext(const SymbolContext *sc,
+                     bool for_playground = false) const override;
   SwiftASTContext *
   GetSwiftASTContextOrNull(const SymbolContext *sc) const override;
   lldb::TargetWP GetTargetWP() const override { return m_target_wp; }