Skip to content

Commit a184c75

Browse files
committed
[BitCodeAnalyzer] Add a few missing TYPE_CODES and MODULE_CODE_COMDAT to GetCodeName
Happened to notice some of these printing as UnknownCode while running llvm-bcanalyzer on a bc file I had. Differential Revision: https://reviews.llvm.org/D86900
1 parent d80ecdf commit a184c75

File tree

3 files changed

+35
-0
lines changed

3 files changed

+35
-0
lines changed

llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ static Optional<const char *> GetCodeName(unsigned CodeID, unsigned BlockID,
135135
STRINGIFY_CODE(MODULE_CODE, FUNCTION)
136136
STRINGIFY_CODE(MODULE_CODE, ALIAS)
137137
STRINGIFY_CODE(MODULE_CODE, GCNAME)
138+
STRINGIFY_CODE(MODULE_CODE, COMDAT)
138139
STRINGIFY_CODE(MODULE_CODE, VSTOFFSET)
139140
STRINGIFY_CODE(MODULE_CODE, METADATA_VALUES_UNUSED)
140141
STRINGIFY_CODE(MODULE_CODE, SOURCE_FILENAME)
@@ -176,16 +177,20 @@ static Optional<const char *> GetCodeName(unsigned CodeID, unsigned BlockID,
176177
STRINGIFY_CODE(TYPE_CODE, OPAQUE)
177178
STRINGIFY_CODE(TYPE_CODE, INTEGER)
178179
STRINGIFY_CODE(TYPE_CODE, POINTER)
180+
STRINGIFY_CODE(TYPE_CODE, HALF)
179181
STRINGIFY_CODE(TYPE_CODE, ARRAY)
180182
STRINGIFY_CODE(TYPE_CODE, VECTOR)
181183
STRINGIFY_CODE(TYPE_CODE, X86_FP80)
182184
STRINGIFY_CODE(TYPE_CODE, FP128)
183185
STRINGIFY_CODE(TYPE_CODE, PPC_FP128)
184186
STRINGIFY_CODE(TYPE_CODE, METADATA)
187+
STRINGIFY_CODE(TYPE_CODE, X86_MMX)
185188
STRINGIFY_CODE(TYPE_CODE, STRUCT_ANON)
186189
STRINGIFY_CODE(TYPE_CODE, STRUCT_NAME)
187190
STRINGIFY_CODE(TYPE_CODE, STRUCT_NAMED)
188191
STRINGIFY_CODE(TYPE_CODE, FUNCTION)
192+
STRINGIFY_CODE(TYPE_CODE, TOKEN)
193+
STRINGIFY_CODE(TYPE_CODE, BFLOAT)
189194
}
190195

191196
case bitc::CONSTANTS_BLOCK_ID:
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
; RUN: llvm-as < %s | llvm-bcanalyzer -dump | FileCheck %s
2+
3+
; CHECK: <COMDAT
4+
$comdat.any = comdat any
5+
@comdat.any = global i32 0, comdat

llvm/test/Bitcode/bcanalyzer-types.ll

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
; RUN: llvm-as < %s | llvm-bcanalyzer -dump | FileCheck %s
2+
3+
; CHECK: Block ID {{.*}} (TYPE_BLOCK_ID)
4+
; CHECK: BFLOAT
5+
; CHECK: TOKEN
6+
; CHECK: X86_MMX
7+
; CHECK: HALF
8+
; CHECK: Block ID
9+
10+
define half @test_half(half %x, half %y) {
11+
%a = fadd half %x, %y
12+
ret half %a
13+
}
14+
15+
define x86_mmx @test_mmx(<2 x i32> %x) {
16+
%a = bitcast <2 x i32> %x to x86_mmx
17+
ret x86_mmx %a
18+
}
19+
20+
define bfloat @test_bfloat(i16 %x) {
21+
%a = bitcast i16 %x to bfloat
22+
ret bfloat %a
23+
}
24+
25+
declare void @llvm.token(token)

0 commit comments

Comments
 (0)