move function type handling into SwiftLanguageRuntimeImpl

Author: kastiglione

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp

@@ -2075,16 +2075,13 @@ uint32_t
 TypeSystemSwiftTypeRef::GetNumChildren(opaque_compiler_type_t type,
                                        bool omit_empty_base_classes,
                                        const ExecutionContext *exe_ctx) {
-  if (IsFunctionType(type, nullptr))
-    return 0;
-
   if (exe_ctx)
     if (auto *exe_scope = exe_ctx->GetBestExecutionContextScope())
       if (auto *runtime =
               SwiftLanguageRuntime::Get(exe_scope->CalculateProcess()))
         if (auto num_children =
                 runtime->GetNumChildren(GetCanonicalType(type), nullptr)) {
-          // Use lambda to intercept and unwrap the `Optional` return value.
+          // Use a lambda to intercept and unwrap the `Optional` return value.
           return [&]() {
             auto impl = [&]() { return num_children; };
             VALIDATE_AND_RETURN(

lldb/source/Target/SwiftLanguageRuntimeDynamicTypeResolution.cpp

@@ -1012,14 +1012,20 @@ SwiftLanguageRuntimeImpl::GetNumChildren(CompilerType type,
   // Structs and Tuples.
   if (auto *rti =
           llvm::dyn_cast_or_null<swift::reflection::RecordTypeInfo>(ti)) {
-    // `OpaqueExistential` is documented as:
-    //     An existential is a three-word buffer followed by value metadata...
-    // The buffer is exposed by as children named `payload_data_{0,1,2}`, and
-    // requires the number of fields to be increased.
-    if (rti->getRecordKind() ==
-        swift::reflection::RecordKind::OpaqueExistential)
+    switch (rti->getRecordKind()) {
+    case swift::reflection::RecordKind::ThickFunction:
+      // There are two fields, `function` and `context`, but they're not exposed
+      // by lldb.
+      return 0;
+    case swift::reflection::RecordKind::OpaqueExistential:
+      // `OpaqueExistential` is documented as:
+      //     An existential is a three-word buffer followed by value metadata...
+      // The buffer is exposed as children named `payload_data_{0,1,2}`, and
+      // the number of fields are increased to match.
       return rti->getNumFields() + 3;
-    return rti->getNumFields();
+    default:
+      return rti->getNumFields();
+    }
   }
   if (auto *eti = llvm::dyn_cast_or_null<swift::reflection::EnumTypeInfo>(ti)) {
     return eti->getNumPayloadCases();