Skip to content

Commit a8abd19

Browse files
committed
[x86] simplify code; NFC
We bail out if the types don't match, so it's clearer to have a single variable to show that common type.
1 parent 5424fb1 commit a8abd19

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

llvm/lib/Target/X86/X86ISelLowering.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45801,10 +45801,8 @@ static SDValue combineAndMaskToShift(SDNode *N, SelectionDAG &DAG,
4580145801
const X86Subtarget &Subtarget) {
4580245802
SDValue Op0 = peekThroughBitcasts(N->getOperand(0));
4580345803
SDValue Op1 = peekThroughBitcasts(N->getOperand(1));
45804-
EVT VT0 = Op0.getValueType();
45805-
EVT VT1 = Op1.getValueType();
45806-
45807-
if (VT0 != VT1 || !VT0.isSimple() || !VT0.isInteger())
45804+
EVT VT = Op0.getValueType();
45805+
if (VT != Op1.getValueType() || !VT.isSimple() || !VT.isInteger())
4580845806
return SDValue();
4580945807

4581045808
APInt SplatVal;
@@ -45816,17 +45814,17 @@ static SDValue combineAndMaskToShift(SDNode *N, SelectionDAG &DAG,
4581645814
if (isBitwiseNot(Op0))
4581745815
return SDValue();
4581845816

45819-
if (!supportedVectorShiftWithImm(VT0.getSimpleVT(), Subtarget, ISD::SRL))
45817+
if (!supportedVectorShiftWithImm(VT.getSimpleVT(), Subtarget, ISD::SRL))
4582045818
return SDValue();
4582145819

45822-
unsigned EltBitWidth = VT0.getScalarSizeInBits();
45820+
unsigned EltBitWidth = VT.getScalarSizeInBits();
4582345821
if (EltBitWidth != DAG.ComputeNumSignBits(Op0))
4582445822
return SDValue();
4582545823

4582645824
SDLoc DL(N);
4582745825
unsigned ShiftVal = SplatVal.countTrailingOnes();
4582845826
SDValue ShAmt = DAG.getTargetConstant(EltBitWidth - ShiftVal, DL, MVT::i8);
45829-
SDValue Shift = DAG.getNode(X86ISD::VSRLI, DL, VT0, Op0, ShAmt);
45827+
SDValue Shift = DAG.getNode(X86ISD::VSRLI, DL, VT, Op0, ShAmt);
4583045828
return DAG.getBitcast(N->getValueType(0), Shift);
4583145829
}
4583245830

0 commit comments

Comments
 (0)