Skip to content

Commit ab25757

Browse files
committed
Remove a top-level "using namespace" directive from LegalizationArtifactCombiner.h
The directive pollutes the namespace of all files including that header. Move the directive into the bodies of functions that need it instead.
1 parent c7fc720 commit ab25757

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#include "llvm/Support/Debug.h"
2929

3030
#define DEBUG_TYPE "legalizer"
31-
using namespace llvm::MIPatternMatch;
3231

3332
namespace llvm {
3433
class LegalizationArtifactCombiner {
@@ -57,6 +56,7 @@ class LegalizationArtifactCombiner {
5756
SmallVectorImpl<MachineInstr *> &DeadInsts,
5857
SmallVectorImpl<Register> &UpdatedDefs,
5958
GISelObserverWrapper &Observer) {
59+
using namespace llvm::MIPatternMatch;
6060
assert(MI.getOpcode() == TargetOpcode::G_ANYEXT);
6161

6262
Builder.setInstrAndDebugLoc(MI);
@@ -110,6 +110,7 @@ class LegalizationArtifactCombiner {
110110
SmallVectorImpl<MachineInstr *> &DeadInsts,
111111
SmallVectorImpl<Register> &UpdatedDefs,
112112
GISelObserverWrapper &Observer) {
113+
using namespace llvm::MIPatternMatch;
113114
assert(MI.getOpcode() == TargetOpcode::G_ZEXT);
114115

115116
Builder.setInstrAndDebugLoc(MI);
@@ -171,6 +172,7 @@ class LegalizationArtifactCombiner {
171172
bool tryCombineSExt(MachineInstr &MI,
172173
SmallVectorImpl<MachineInstr *> &DeadInsts,
173174
SmallVectorImpl<Register> &UpdatedDefs) {
175+
using namespace llvm::MIPatternMatch;
174176
assert(MI.getOpcode() == TargetOpcode::G_SEXT);
175177

176178
Builder.setInstrAndDebugLoc(MI);
@@ -228,6 +230,7 @@ class LegalizationArtifactCombiner {
228230
SmallVectorImpl<MachineInstr *> &DeadInsts,
229231
SmallVectorImpl<Register> &UpdatedDefs,
230232
GISelObserverWrapper &Observer) {
233+
using namespace llvm::MIPatternMatch;
231234
assert(MI.getOpcode() == TargetOpcode::G_TRUNC);
232235

233236
Builder.setInstr(MI);
@@ -1282,6 +1285,8 @@ class LegalizationArtifactCombiner {
12821285
/// Looks through copy instructions and returns the actual
12831286
/// source register.
12841287
Register lookThroughCopyInstrs(Register Reg) {
1288+
using namespace llvm::MIPatternMatch;
1289+
12851290
Register TmpReg;
12861291
while (mi_match(Reg, MRI, m_Copy(m_Reg(TmpReg)))) {
12871292
if (MRI.getType(TmpReg).isValid())

0 commit comments

Comments
 (0)