Skip to content

Commit af3c51e

Browse files
committed
[gn build] Add missing clangd dependencies
Fixes $ ninja obj/build/rel/gen/clang-tools-extra/clangd/CompletionModel.CompletionModel.obj Some tablegen include files from clang/include/clang/AST and clang/include/clang/Sema need to be generated before CompletionModel is compiled. Reviewed By: thakis Differential Revision: https://reviews.llvm.org/D89657
1 parent 710676c commit af3c51e

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

llvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ gen_decision_forest("CompletionModel") {
2525
model = "quality/model"
2626
filename = "CompletionModel"
2727
cpp_class = "clang::clangd::Example"
28+
deps = [ "//clang/lib/Sema" ]
2829
}
2930

3031
static_library("clangd") {

llvm/utils/gn/secondary/clang-tools-extra/clangd/quality/gen_decision_forest.gni

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@ template("gen_decision_forest") {
22
model = invoker.model
33
filename = invoker.filename
44
cpp_class = invoker.cpp_class
5+
if (defined(invoker.deps)) {
6+
extra_deps = invoker.deps
7+
} else {
8+
extra_deps = []
9+
}
510

611
action("${target_name}Cpp") {
712
script = "//clang-tools-extra/clangd/quality/CompletionModelCodegen.py"
@@ -34,7 +39,7 @@ template("gen_decision_forest") {
3439
"//llvm/utils/gn/build:clang_code",
3540
":${target_name}Config",
3641
]
37-
deps = [ ":${target_name}Cpp" ]
42+
deps = [ ":${target_name}Cpp" ] + extra_deps
3843
include_dirs = [ "." ]
3944
sources = get_target_outputs(":${target_name}Cpp")
4045
}

0 commit comments

Comments
 (0)