Merge pull request #10598 from felipepiovezan/felipe/disable_dap_flaky_tests

[cherry-pick][lldb] Disable flaky dap tests

Author: JDevlieghere

lldb/packages/Python/lldbsuite/test/decorators.py

@@ -398,6 +398,10 @@ def skipIf(
     )
 
 
+def skip(bugnumber=None):
+    return _decorateTest(DecorateMode.Skip, bugnumber=bugnumber)
+
+
 def _skip_fn_for_android(reason, api_levels, archs):
     def impl():
         result = lldbplatformutil.match_android_device(

lldb/test/API/commands/expression/import-std-module/pair/TestPairFromStdModule.py

@@ -13,7 +13,7 @@ class TestCase(TestBase):
     # FIXME: This regressed in 69d5a6662115499198ebfa07a081e98a6ce4b915
     # but needs further investigation for what underlying Clang/LLDB bug can't
     # handle that code change.
-    @skipIf
+    @skip
     def test(self):
         self.build()
 

lldb/test/API/commands/watchpoints/variable_out_of_scope/TestWatchedVarHitWhenInScope.py

@@ -28,7 +28,7 @@ def setUp(self):
 
     # Test hangs due to a kernel bug, see fdfeff0f in the linux kernel for details
     @skipIfTargetAndroid(api_levels=list(range(25 + 1)), archs=["aarch64", "arm"])
-    @skipIf
+    @skip
     def test_watched_var_should_only_hit_when_in_scope(self):
         """Test that a variable watchpoint should only hit when in scope."""
         self.build(dictionary=self.d)

lldb/test/API/lang/objc/bitfield_ivars/TestBitfieldIvars.py

@@ -42,7 +42,7 @@ def test(self):
 
     # This test is meant to be xfailed, but running the test triggers an ASan
     # issue, so it must be skipped for now.
-    @skipIf
+    @skip
     def testExprWholeObject(self):
         self.build()
         lldbutil.run_to_source_breakpoint(

lldb/test/API/tools/lldb-dap/attach/TestDAP_attach.py

@@ -25,6 +25,7 @@ def spawn_and_wait(program, delay):
     process.wait()
 
 
+@skipIf
 class TestDAP_attach(lldbdap_testcase.DAPTestCaseBase):
     def set_and_hit_breakpoint(self, continueToExit=True):
         source = "main.c"

lldb/test/API/tools/lldb-dap/attach/TestDAP_attachByPortNum.py

@@ -19,6 +19,7 @@
 import socket
 
 
+@skip
 class TestDAP_attachByPortNum(lldbdap_testcase.DAPTestCaseBase):
     default_timeout = 20
 

lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_breakpointLocations.py

@@ -11,7 +11,8 @@
 import lldbdap_testcase
 import os
 
-
+# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
+@skip
 class TestDAP_breakpointLocations(lldbdap_testcase.DAPTestCaseBase):
     def setUp(self):
         lldbdap_testcase.DAPTestCaseBase.setUp(self)

lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_setBreakpoints.py

@@ -11,7 +11,8 @@
 import lldbdap_testcase
 import os
 
-
+# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
+@skip
 class TestDAP_setBreakpoints(lldbdap_testcase.DAPTestCaseBase):
     def setUp(self):
         lldbdap_testcase.DAPTestCaseBase.setUp(self)

lldb/test/API/tools/lldb-dap/commands/TestDAP_commands.py

@@ -5,7 +5,8 @@
 from lldbsuite.test import lldbtest, lldbutil
 from lldbsuite.test.decorators import *
 
-
+# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
+@skip
 class TestDAP_commands(lldbdap_testcase.DAPTestCaseBase):
     def test_command_directive_quiet_on_success(self):
         program = self.getBuildArtifact("a.out")

lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py

@@ -10,7 +10,8 @@
 import lldbdap_testcase
 import os
 
-
+# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
+@skip
 class TestDAP_disassemble(lldbdap_testcase.DAPTestCaseBase):
     @skipIfWindows
     def test_disassemble(self):

lldb/test/API/tools/lldb-dap/evaluate/TestDAP_evaluate.py

@@ -10,7 +10,8 @@
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
-
+# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
+@skip
 class TestDAP_evaluate(lldbdap_testcase.DAPTestCaseBase):
     def assertEvaluate(self, expression, regex):
         self.assertRegex(

lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py

@@ -10,7 +10,8 @@
 import lldbdap_testcase
 import os
 
-
+# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
+@skip
 class TestDAP_memory(lldbdap_testcase.DAPTestCaseBase):
     def test_memory_refs_variables(self):
         """

lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py

@@ -17,7 +17,8 @@ def make_buffer_verify_dict(start_idx, count, offset=0):
         verify_dict["[%i]" % (i)] = {"type": "int", "value": str(i + offset)}
     return verify_dict
 
-
+# DAP tests are flakey, see https://github.com/llvm/llvm-project/issues/137660.
+@skip
 class TestDAP_variables(lldbdap_testcase.DAPTestCaseBase):
     def verify_values(self, verify_dict, actual, varref_dict=None, expression=None):
         if "equals" in verify_dict: