Skip to content

Commit b9813ce

Browse files
authored
[LLDB][LLDB-DAP] Wire up DAP to listen to external progress events (llvm#123826)
Recently I added SBProgress (llvm#119052), and during that original commit I tested if the progress event was sent over LLDB-DAP, and it was. However upon the suggestion of @JDevlieghere and @labath we added an external category (llvm#120171), which I did not test. This small patch wires up DAP to listen for external events by default, and adds the external category to the SBDebugger enumeration.
1 parent d25a1f8 commit b9813ce

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

lldb/include/lldb/API/SBDebugger.h

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,16 @@ class LLDB_API SBInputReader {
4242

4343
class LLDB_API SBDebugger {
4444
public:
45-
FLAGS_ANONYMOUS_ENUM(){
46-
eBroadcastBitProgress = lldb::DebuggerBroadcastBit::eBroadcastBitProgress,
47-
eBroadcastBitWarning = lldb::DebuggerBroadcastBit::eBroadcastBitWarning,
48-
eBroadcastBitError = lldb::DebuggerBroadcastBit::eBroadcastBitError,
49-
eBroadcastBitProgressCategory =
50-
lldb::DebuggerBroadcastBit::eBroadcastBitProgressCategory,
45+
FLAGS_ANONYMOUS_ENUM() {
46+
eBroadcastBitProgress = lldb::DebuggerBroadcastBit::eBroadcastBitProgress,
47+
eBroadcastBitWarning = lldb::DebuggerBroadcastBit::eBroadcastBitWarning,
48+
eBroadcastBitError = lldb::DebuggerBroadcastBit::eBroadcastBitError,
49+
eBroadcastBitProgressCategory =
50+
lldb::DebuggerBroadcastBit::eBroadcastBitProgressCategory,
51+
eBroadcastBitExternalProgress =
52+
lldb::DebuggerBroadcastBit::eBroadcastBitExternalProgress,
53+
eBroadcastBitExternalProgressCategory =
54+
lldb::DebuggerBroadcastBit::eBroadcastBitExternalProgressCategory,
5155
};
5256
SBDebugger();
5357

lldb/tools/lldb-dap/lldb-dap.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,8 @@ void SendStdOutStdErr(DAP &dap, lldb::SBProcess &process) {
414414
void ProgressEventThreadFunction(DAP &dap) {
415415
lldb::SBListener listener("lldb-dap.progress.listener");
416416
dap.debugger.GetBroadcaster().AddListener(
417-
listener, lldb::SBDebugger::eBroadcastBitProgress);
417+
listener, lldb::SBDebugger::eBroadcastBitProgress |
418+
lldb::SBDebugger::eBroadcastBitExternalProgress);
418419
dap.broadcaster.AddListener(listener, eBroadcastBitStopProgressThread);
419420
lldb::SBEvent event;
420421
bool done = false;

0 commit comments

Comments
 (0)