🍒 [llvm][MetadataLoader] Make sure we correctly load DW_APPLE_ENUM_KIND from bitcode

This was pointed out in llvm#124752 (comment)

There was no test that roundtrips this attribute through LLVM bitcode, so this was never caught.

Author: Michael137

llvm/lib/Bitcode/Reader/MetadataLoader.cpp

@@ -1689,8 +1689,8 @@ Error MetadataLoader::MetadataLoaderImpl::parseOneMetadata(
       }
     }
 
-    if (Record.size() > 25 && Record[25] != dwarf::DW_APPLE_ENUM_KIND_invalid)
-      EnumKind = Record[25];
+    if (Record.size() > 24 && Record[24] != dwarf::DW_APPLE_ENUM_KIND_invalid)
+      EnumKind = Record[24];
 
     DICompositeType *CT = nullptr;
     if (Identifier)

llvm/test/DebugInfo/AArch64/DW_AT_APPLE_enum_kind.ll

@@ -1,5 +1,7 @@
 ; RUN: llc < %s -filetype=obj -o %t
 ; RUN: llvm-dwarfdump -v %t | FileCheck %s
+;
+; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s --check-prefix=CHECK-METADATA
 
 ; C++ source to regenerate:
 ; enum __attribute__((enum_extensibility(open))) OpenEnum {
@@ -12,6 +14,8 @@
 ; 
 ; $ clang++ -O0 -g debug-info-enum-kind.cpp -c
 
+; CHECK-METADATA: enumKind: DW_APPLE_ENUM_KIND_Open
+; CHECK-METADATA: enumKind: DW_APPLE_ENUM_KIND_Closed
 
 ; CHECK: .debug_abbrev contents: