Merge pull request #1493 from adrian-prantl/complete

Hoist GetCompleteType from SwiftASTContext into TypeSystemSwift (NFC)

Author: adrian-prantl

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp

@@ -5322,10 +5322,6 @@ SwiftASTContext::GetAllocationStrategy(opaque_compiler_type_t type) {
 // Type Completion
 //----------------------------------------------------------------------
 
-bool SwiftASTContext::GetCompleteType(opaque_compiler_type_t type) {
-  return true;
-}
-
 ConstString SwiftASTContext::GetTypeName(opaque_compiler_type_t type) {
   std::string type_name;
   if (type) {

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.h

@@ -515,10 +515,6 @@ class SwiftASTContext : public TypeSystemSwift {
       const CompilerType &type, NonTriviallyManagedReferenceStrategy &strategy,
       CompilerType *underlying_type = nullptr);
 
-  // Type Completion
-
-  bool GetCompleteType(lldb::opaque_compiler_type_t type) override;
-
   // AST related queries
 
   uint32_t GetPointerByteSize() override;

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwift.h

@@ -159,6 +159,9 @@ class TypeSystemSwift : public TypeSystem {
   bool IsBeingDefined(lldb::opaque_compiler_type_t type) override {
     return false;
   }
+  bool GetCompleteType(lldb::opaque_compiler_type_t type) override {
+    return true;
+  }
   bool CanPassInRegisters(const CompilerType &type) override {
     // FIXME: Implement this. There was an abort() here to figure out which
     // tests where hitting this code. At least TestSwiftReturns and

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp

@@ -1385,10 +1385,6 @@ bool TypeSystemSwiftTypeRef::IsVoidType(opaque_compiler_type_t type) {
   };
   VALIDATE_AND_RETURN(impl, IsVoidType, type, (ReconstructType(type)));
 }
-// Type Completion
-bool TypeSystemSwiftTypeRef::GetCompleteType(opaque_compiler_type_t type) {
-  return m_swift_ast_context->GetCompleteType(ReconstructType(type));
-}
 // AST related queries
 uint32_t TypeSystemSwiftTypeRef::GetPointerByteSize() {
   return m_swift_ast_context->GetPointerByteSize();

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.h

@@ -101,8 +101,6 @@ class TypeSystemSwiftTypeRef : public TypeSystemSwift {
   bool IsPointerType(lldb::opaque_compiler_type_t type,
                      CompilerType *pointee_type) override;
   bool IsVoidType(lldb::opaque_compiler_type_t type) override;
-  // Type Completion
-  bool GetCompleteType(lldb::opaque_compiler_type_t type) override;
   // AST related queries
   uint32_t GetPointerByteSize() override;
   // Accessors