Skip to content

Commit c2f6460

Browse files
JDevlieghereJDevlieghere
committed
[lldb] Update the NativeRegisterContext to take a WritableMemoryBuffer
1 parent 1e08544 commit c2f6460

35 files changed

+35
-35
lines changed

‎lldb/include/lldb/Host/common/NativeRegisterContext.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class NativeRegisterContext
5151
virtual Status WriteRegister(const RegisterInfo *reg_info,
5252
const RegisterValue &reg_value) = 0;
5353

54-
virtual Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) = 0;
54+
virtual Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) = 0;
5555

5656
virtual Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) = 0;
5757

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ Status NativeRegisterContextFreeBSD_arm::WriteRegister(
140140
}
141141

142142
Status NativeRegisterContextFreeBSD_arm::ReadAllRegisterValues(
143-
lldb::DataBufferSP &data_sp) {
143+
lldb::WritableDataBufferSP &data_sp) {
144144
Status error;
145145

146146
error = ReadRegisterSet(RegisterInfoPOSIX_arm::GPRegSet);

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class NativeRegisterContextFreeBSD_arm : public NativeRegisterContextFreeBSD {
4444
Status WriteRegister(const RegisterInfo *reg_info,
4545
const RegisterValue &reg_value) override;
4646

47-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
47+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4848

4949
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
5050

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ Status NativeRegisterContextFreeBSD_arm64::WriteRegister(
149149
}
150150

151151
Status NativeRegisterContextFreeBSD_arm64::ReadAllRegisterValues(
152-
lldb::DataBufferSP &data_sp) {
152+
lldb::WritableDataBufferSP &data_sp) {
153153
Status error;
154154

155155
error = ReadRegisterSet(RegisterInfoPOSIX_arm64::GPRegSet);

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class NativeRegisterContextFreeBSD_arm64
5151
Status WriteRegister(const RegisterInfo *reg_info,
5252
const RegisterValue &reg_value) override;
5353

54-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
54+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
5555

5656
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
5757

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_mips64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ Status NativeRegisterContextFreeBSD_mips64::WriteRegister(
176176
}
177177

178178
Status NativeRegisterContextFreeBSD_mips64::ReadAllRegisterValues(
179-
lldb::DataBufferSP &data_sp) {
179+
lldb::WritableDataBufferSP &data_sp) {
180180
Status error;
181181

182182
error = ReadRegisterSet(GPRegSet);

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_mips64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class NativeRegisterContextFreeBSD_mips64
4444
Status WriteRegister(const RegisterInfo *reg_info,
4545
const RegisterValue &reg_value) override;
4646

47-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
47+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4848

4949
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
5050

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_powerpc.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ Status NativeRegisterContextFreeBSD_powerpc::WriteRegister(
227227
}
228228

229229
Status NativeRegisterContextFreeBSD_powerpc::ReadAllRegisterValues(
230-
lldb::DataBufferSP &data_sp) {
230+
lldb::WritableDataBufferSP &data_sp) {
231231
Status error;
232232

233233
error = ReadRegisterSet(GPRegSet);

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_powerpc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class NativeRegisterContextFreeBSD_powerpc
4444
Status WriteRegister(const RegisterInfo *reg_info,
4545
const RegisterValue &reg_value) override;
4646

47-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
47+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4848

4949
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
5050

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_x86_64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ Status NativeRegisterContextFreeBSD_x86_64::WriteRegister(
537537
}
538538

539539
Status NativeRegisterContextFreeBSD_x86_64::ReadAllRegisterValues(
540-
lldb::DataBufferSP &data_sp) {
540+
lldb::WritableDataBufferSP &data_sp) {
541541
Status error;
542542

543543
data_sp.reset(new DataBufferHeap(REG_CONTEXT_SIZE, 0));

‎lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_x86_64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class NativeRegisterContextFreeBSD_x86_64
4848
Status WriteRegister(const RegisterInfo *reg_info,
4949
const RegisterValue &reg_value) override;
5050

51-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
51+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
5252

5353
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
5454

‎lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1240,7 +1240,7 @@ NativeProcessLinux::Syscall(llvm::ArrayRef<uint64_t> args) {
12401240
NativeRegisterContextLinux::SyscallData syscall_data =
12411241
*reg_ctx.GetSyscallData();
12421242

1243-
DataBufferSP registers_sp;
1243+
WritableDataBufferSP registers_sp;
12441244
if (llvm::Error Err = reg_ctx.ReadAllRegisterValues(registers_sp).ToError())
12451245
return std::move(Err);
12461246
auto restore_regs = llvm::make_scope_exit(

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ NativeRegisterContextLinux_arm::WriteRegister(const RegisterInfo *reg_info,
192192
}
193193

194194
Status NativeRegisterContextLinux_arm::ReadAllRegisterValues(
195-
lldb::DataBufferSP &data_sp) {
195+
lldb::WritableDataBufferSP &data_sp) {
196196
Status error;
197197

198198
data_sp.reset(new DataBufferHeap(REG_CONTEXT_SIZE, 0));

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class NativeRegisterContextLinux_arm : public NativeRegisterContextLinux {
3737
Status WriteRegister(const RegisterInfo *reg_info,
3838
const RegisterValue &reg_value) override;
3939

40-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
40+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4141

4242
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4343

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ Status NativeRegisterContextLinux_arm64::WriteRegister(
449449
}
450450

451451
Status NativeRegisterContextLinux_arm64::ReadAllRegisterValues(
452-
lldb::DataBufferSP &data_sp) {
452+
lldb::WritableDataBufferSP &data_sp) {
453453
// AArch64 register data must contain GPRs, either FPR or SVE registers
454454
// and optional MTE register. Pointer Authentication (PAC) registers are
455455
// read-only and will be skiped.

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class NativeRegisterContextLinux_arm64
4343
Status WriteRegister(const RegisterInfo *reg_info,
4444
const RegisterValue &reg_value) override;
4545

46-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
46+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4747

4848
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4949

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ Status NativeRegisterContextLinux_ppc64le::WriteRegister(
349349
}
350350

351351
Status NativeRegisterContextLinux_ppc64le::ReadAllRegisterValues(
352-
lldb::DataBufferSP &data_sp) {
352+
lldb::WritableDataBufferSP &data_sp) {
353353
Status error;
354354

355355
data_sp.reset(new DataBufferHeap(REG_CONTEXT_SIZE, 0));

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class NativeRegisterContextLinux_ppc64le : public NativeRegisterContextLinux {
4343
Status WriteRegister(const RegisterInfo *reg_info,
4444
const RegisterValue &reg_value) override;
4545

46-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
46+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4747

4848
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4949

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ Status NativeRegisterContextLinux_s390x::WriteRegister(
328328
}
329329

330330
Status NativeRegisterContextLinux_s390x::ReadAllRegisterValues(
331-
lldb::DataBufferSP &data_sp) {
331+
lldb::WritableDataBufferSP &data_sp) {
332332
Status error;
333333

334334
data_sp.reset(new DataBufferHeap(REG_CONTEXT_SIZE, 0));

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class NativeRegisterContextLinux_s390x : public NativeRegisterContextLinux {
3838
Status WriteRegister(const RegisterInfo *reg_info,
3939
const RegisterValue &reg_value) override;
4040

41-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
41+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4242

4343
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4444

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,7 @@ Status NativeRegisterContextLinux_x86_64::WriteRegister(
689689
}
690690

691691
Status NativeRegisterContextLinux_x86_64::ReadAllRegisterValues(
692-
lldb::DataBufferSP &data_sp) {
692+
lldb::WritableDataBufferSP &data_sp) {
693693
Status error;
694694

695695
data_sp.reset(new DataBufferHeap(REG_CONTEXT_SIZE, 0));

‎lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class NativeRegisterContextLinux_x86_64
4141
Status WriteRegister(const RegisterInfo *reg_info,
4242
const RegisterValue &reg_value) override;
4343

44-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
44+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
4545

4646
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4747

‎lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ Status NativeRegisterContextNetBSD_x86_64::WriteRegister(
527527
}
528528

529529
Status NativeRegisterContextNetBSD_x86_64::ReadAllRegisterValues(
530-
lldb::DataBufferSP &data_sp) {
530+
lldb::WritableDataBufferSP &data_sp) {
531531
Status error;
532532

533533
data_sp.reset(new DataBufferHeap(REG_CONTEXT_SIZE, 0));

‎lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class NativeRegisterContextNetBSD_x86_64
4646
Status WriteRegister(const RegisterInfo *reg_info,
4747
const RegisterValue &reg_value) override;
4848

49-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
49+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
5050

5151
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
5252

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ Status NativeRegisterContextWindows_WoW64::WriteRegister(
367367
}
368368

369369
Status NativeRegisterContextWindows_WoW64::ReadAllRegisterValues(
370-
lldb::DataBufferSP &data_sp) {
370+
lldb::WritableDataBufferSP &data_sp) {
371371
const size_t data_size = REG_CONTEXT_SIZE;
372372
data_sp = std::make_shared<DataBufferHeap>(data_size, 0);
373373
::WOW64_CONTEXT tls_context;

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class NativeRegisterContextWindows_WoW64 : public NativeRegisterContextWindows {
3434
Status WriteRegister(const RegisterInfo *reg_info,
3535
const RegisterValue &reg_value) override;
3636

37-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
37+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
3838

3939
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4040

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ Status NativeRegisterContextWindows_arm::WriteRegister(
560560
}
561561

562562
Status NativeRegisterContextWindows_arm::ReadAllRegisterValues(
563-
lldb::DataBufferSP &data_sp) {
563+
lldb::WritableDataBufferSP &data_sp) {
564564
const size_t data_size = REG_CONTEXT_SIZE;
565565
data_sp = std::make_shared<DataBufferHeap>(data_size, 0);
566566
::CONTEXT tls_context;

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class NativeRegisterContextWindows_arm : public NativeRegisterContextWindows {
3333
Status WriteRegister(const RegisterInfo *reg_info,
3434
const RegisterValue &reg_value) override;
3535

36-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
36+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
3737

3838
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
3939

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ Status NativeRegisterContextWindows_arm64::WriteRegister(
670670
}
671671

672672
Status NativeRegisterContextWindows_arm64::ReadAllRegisterValues(
673-
lldb::DataBufferSP &data_sp) {
673+
lldb::WritableDataBufferSP &data_sp) {
674674
const size_t data_size = REG_CONTEXT_SIZE;
675675
data_sp = std::make_shared<DataBufferHeap>(data_size, 0);
676676
::CONTEXT tls_context;

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class NativeRegisterContextWindows_arm64 : public NativeRegisterContextWindows {
3333
Status WriteRegister(const RegisterInfo *reg_info,
3434
const RegisterValue &reg_value) override;
3535

36-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
36+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
3737

3838
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
3939

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ Status NativeRegisterContextWindows_i386::WriteRegister(
376376
}
377377

378378
Status NativeRegisterContextWindows_i386::ReadAllRegisterValues(
379-
lldb::DataBufferSP &data_sp) {
379+
lldb::WritableDataBufferSP &data_sp) {
380380
const size_t data_size = REG_CONTEXT_SIZE;
381381
data_sp = std::make_shared<DataBufferHeap>(data_size, 0);
382382
::CONTEXT tls_context;

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class NativeRegisterContextWindows_i386 : public NativeRegisterContextWindows {
3434
Status WriteRegister(const RegisterInfo *reg_info,
3535
const RegisterValue &reg_value) override;
3636

37-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
37+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
3838

3939
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4040

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@ Status NativeRegisterContextWindows_x86_64::WriteRegister(
579579
}
580580

581581
Status NativeRegisterContextWindows_x86_64::ReadAllRegisterValues(
582-
lldb::DataBufferSP &data_sp) {
582+
lldb::WritableDataBufferSP &data_sp) {
583583
const size_t data_size = REG_CONTEXT_SIZE;
584584
data_sp = std::make_shared<DataBufferHeap>(data_size, 0);
585585
::CONTEXT tls_context;

‎lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class NativeRegisterContextWindows_x86_64
3535
Status WriteRegister(const RegisterInfo *reg_info,
3636
const RegisterValue &reg_value) override;
3737

38-
Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
38+
Status ReadAllRegisterValues(lldb::WritableDataBufferSP &data_sp) override;
3939

4040
Status WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
4141

‎lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3053,7 +3053,7 @@ GDBRemoteCommunicationServerLLGS::Handle_QSaveRegisterState(
30533053
NativeRegisterContext& reg_context = thread->GetRegisterContext();
30543054

30553055
// Save registers to a buffer.
3056-
DataBufferSP register_data_sp;
3056+
WritableDataBufferSP register_data_sp;
30573057
Status error = reg_context.ReadAllRegisterValues(register_data_sp);
30583058
if (error.Fail()) {
30593059
LLDB_LOG(log, "pid {0} failed to save all register values: {1}",

0 commit comments

Comments
 (0)