Merge pull request #1449 from adrian-prantl/isdefined

Implement TypeSystemSwiftTypeRef::IsDefined (NFC)

Author: adrian-prantl

lldb/source/Symbol/TypeSystemSwiftTypeRef.cpp

@@ -931,7 +931,10 @@ bool TypeSystemSwiftTypeRef::IsAggregateType(opaque_compiler_type_t type) {
 }
 
 bool TypeSystemSwiftTypeRef::IsDefined(opaque_compiler_type_t type) {
-  return m_swift_ast_context->IsDefined(ReconstructType(type));
+  auto impl = [&]() -> bool {
+    return type;
+  };
+  VALIDATE_AND_RETURN(impl, IsDefined, type, (ReconstructType(type)));
 }
 bool TypeSystemSwiftTypeRef::IsFloatingPointType(opaque_compiler_type_t type,
                                                  uint32_t &count,

lldb/unittests/Symbol/TestTypeSystemSwiftTypeRef.cpp

@@ -267,3 +267,16 @@ TEST_F(TestTypeSystemSwiftTypeRef, Aggregate) {
     ASSERT_FALSE(tau.IsAggregateType());
   }
 }
+
+TEST_F(TestTypeSystemSwiftTypeRef, Defined) {
+  using namespace swift::Demangle;
+  Demangler dem;
+  NodeBuilder b(dem);
+  {
+    NodePointer int_node = b.GlobalTypeMangling(b.IntType());
+    CompilerType int_type = GetCompilerType(b.Mangle(int_node));
+    ASSERT_TRUE(int_type.IsDefined());
+    // It's technically not possible to construct such a CompilerType.
+    ASSERT_FALSE(m_swift_ts.IsDefined(nullptr));
+  }
+}