Skip to content

Commit cc12b57

Browse files
[lldb] Override Should{Select,Show} in StopReasonBreakpoint (llvm#135637)
This is necessary so that LLDB does not select (or show the stop reason for) a thread which stopped at an internal breakpoint. Other than manual testing/inspection, which I've done, this does not seem to lend itself to API testing, as we cannot set internal breakpoints through the SBAPI. (cherry picked from commit 7491ff7)
1 parent df51a1b commit cc12b57

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lldb/source/Target/StopInfo.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,10 @@ class StopInfoBreakpoint : public StopInfo {
263263
return bp_site_sp->GetSuggestedStackFrameIndex();
264264
}
265265

266+
bool ShouldShow() const override { return !m_was_all_internal; }
267+
268+
bool ShouldSelect() const override { return !m_was_all_internal; }
269+
266270
protected:
267271
bool ShouldStop(Event *event_ptr) override {
268272
// This just reports the work done by PerformAction or the synchronous

0 commit comments

Comments
 (0)