Skip to content

Commit cffa41f

Browse files
JDevlieghereusama54321
authored andcommitted
[lldb] Remove workaround in InstrumentationRuntimeASan
The code was commented out because it would trigger an assert in the source manager. I can no longer reproduce the assert and none of the ASan tests are failing with the code re-enabled.
1 parent ac9bb6a commit cffa41f

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,10 @@ StructuredData::ObjectSP InstrumentationRuntimeASan::RetrieveReportData() {
152152

153153
addr_t pc =
154154
return_value_sp->GetValueForExpressionPath(".pc")->GetValueAsUnsigned(0);
155-
/* commented out because rdar://problem/18533301
156155
addr_t bp =
157156
return_value_sp->GetValueForExpressionPath(".bp")->GetValueAsUnsigned(0);
158157
addr_t sp =
159-
return_value_sp->GetValueForExpressionPath(".sp")->GetValueAsUnsigned(0);
160-
*/
158+
return_value_sp->GetValueForExpressionPath(".sp")->GetValueAsUnsigned(0);
161159
addr_t address = return_value_sp->GetValueForExpressionPath(".address")
162160
->GetValueAsUnsigned(0);
163161
addr_t access_type =
@@ -177,10 +175,8 @@ StructuredData::ObjectSP InstrumentationRuntimeASan::RetrieveReportData() {
177175
dict->AddStringItem("instrumentation_class", "AddressSanitizer");
178176
dict->AddStringItem("stop_type", "fatal_error");
179177
dict->AddIntegerItem("pc", pc);
180-
/* commented out because rdar://problem/18533301
181178
dict->AddIntegerItem("bp", bp);
182179
dict->AddIntegerItem("sp", sp);
183-
*/
184180
dict->AddIntegerItem("address", address);
185181
dict->AddIntegerItem("access_type", access_type);
186182
dict->AddIntegerItem("access_size", access_size);

0 commit comments

Comments
 (0)