Skip to content

Commit d3530e9

Browse files
[MLIR][cmake] don't glob for sources.
Generally speaking, this is bad practice. It also causes the build to break if there are editor temporary files. Differential Revision: https://reviews.llvm.org/D79906
1 parent 20db891 commit d3530e9

File tree

3 files changed

+33
-6
lines changed

3 files changed

+33
-6
lines changed

mlir/lib/Dialect/SCF/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
file(GLOB globbed *.c *.cpp)
21
add_mlir_dialect_library(MLIRSCF
3-
${globbed}
2+
SCF.cpp
43
EDSC/Builders.cpp
54

65
ADDITIONAL_HEADER_DIRS

mlir/lib/IR/CMakeLists.txt

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,30 @@
1-
file(GLOB globbed *.c *.cpp)
21
add_mlir_library(MLIRIR
3-
${globbed}
2+
AffineExpr.cpp
3+
AffineMap.cpp
4+
AsmPrinter.cpp
5+
Attributes.cpp
6+
Block.cpp
7+
Builders.cpp
8+
Diagnostics.cpp
9+
Dialect.cpp
10+
Dominance.cpp
11+
Function.cpp
12+
FunctionImplementation.cpp
13+
IntegerSet.cpp
14+
Location.cpp
15+
MLIRContext.cpp
16+
Module.cpp
17+
Operation.cpp
18+
OperationSupport.cpp
19+
PatternMatch.cpp
20+
Region.cpp
21+
StandardTypes.cpp
22+
SymbolTable.cpp
23+
Types.cpp
24+
TypeUtilities.cpp
25+
Value.cpp
26+
Verifier.cpp
27+
Visitors.cpp
428

529
ADDITIONAL_HEADER_DIRS
630
${MLIR_MAIN_INCLUDE_DIR}/mlir/IR

mlir/lib/Pass/CMakeLists.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1-
file(GLOB globbed *.c *.cpp)
21
add_mlir_library(MLIRPass
3-
${globbed}
2+
IRPrinting.cpp
3+
Pass.cpp
4+
PassManagerOptions.cpp
5+
PassRegistry.cpp
6+
PassStatistics.cpp
7+
PassTiming.cpp
48

59
ADDITIONAL_HEADER_DIRS
610
${MLIR_MAIN_INCLUDE_DIR}/mlir/Pass

0 commit comments

Comments
 (0)