Skip to content

Commit d49280e

Browse files
committed
[RISCV] Rename WriteFALU* and ReadFALU* to WriteFAdd*/ReadFAdd*.
ALU seems a little vague. FAdd felt more precise even though it also include FSUB instructions. Reviewed By: monkchiang Differential Revision: https://reviews.llvm.org/D133632
1 parent fc04749 commit d49280e

File tree

6 files changed

+25
-25
lines changed

6 files changed

+25
-25
lines changed

llvm/lib/Target/RISCV/RISCVInstrInfoD.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ defm : FPFMADynFrmAlias_m<FMSUB_D, "fmsub.d", DINX>;
113113
defm : FPFMADynFrmAlias_m<FNMSUB_D, "fnmsub.d", DINX>;
114114
defm : FPFMADynFrmAlias_m<FNMADD_D, "fnmadd.d", DINX>;
115115

116-
let SchedRW = [WriteFALU64, ReadFALU64, ReadFALU64] in {
116+
let SchedRW = [WriteFAdd64, ReadFAdd64, ReadFAdd64] in {
117117
defm FADD_D : FPALU_rr_frm_m<0b0000001, "fadd.d", DINX, /*Commutable*/1>;
118118
defm FSUB_D : FPALU_rr_frm_m<0b0000101, "fsub.d", DINX>;
119119
}

llvm/lib/Target/RISCV/RISCVInstrInfoF.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ defm : FPFMADynFrmAlias_m<FMSUB_S, "fmsub.s", FINX>;
314314
defm : FPFMADynFrmAlias_m<FNMSUB_S, "fnmsub.s", FINX>;
315315
defm : FPFMADynFrmAlias_m<FNMADD_S, "fnmadd.s", FINX>;
316316

317-
let SchedRW = [WriteFALU32, ReadFALU32, ReadFALU32] in {
317+
let SchedRW = [WriteFAdd32, ReadFAdd32, ReadFAdd32] in {
318318
defm FADD_S : FPALU_rr_frm_m<0b0000000, "fadd.s", FINX, /*Commutable*/1>;
319319
defm FSUB_S : FPALU_rr_frm_m<0b0000100, "fsub.s", FINX>;
320320
}

llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ defm : FPFMADynFrmAlias_m<FMSUB_H, "fmsub.h", HINX>;
108108
defm : FPFMADynFrmAlias_m<FNMSUB_H, "fnmsub.h", HINX>;
109109
defm : FPFMADynFrmAlias_m<FNMADD_H, "fnmadd.h", HINX>;
110110

111-
let SchedRW = [WriteFALU16, ReadFALU16, ReadFALU16] in {
111+
let SchedRW = [WriteFAdd16, ReadFAdd16, ReadFAdd16] in {
112112
defm FADD_H : FPALU_rr_frm_m<0b0000010, "fadd.h", HINX, /*Commutable*/1>;
113113
defm FSUB_H : FPALU_rr_frm_m<0b0000110, "fsub.h", HINX>;
114114
}

llvm/lib/Target/RISCV/RISCVSchedRocket.td

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,14 @@ def : WriteRes<WriteAtomicSTD, [RocketUnitMem]>;
111111

112112
// Single precision.
113113
let Latency = 4 in {
114-
def : WriteRes<WriteFALU32, [RocketUnitFPALU]>;
114+
def : WriteRes<WriteFAdd32, [RocketUnitFPALU]>;
115115
def : WriteRes<WriteFSGNJ32, [RocketUnitFPALU]>;
116116
def : WriteRes<WriteFMinMax32, [RocketUnitFPALU]>;
117117
}
118118

119119
// Double precision
120120
let Latency = 6 in {
121-
def : WriteRes<WriteFALU64, [RocketUnitFPALU]>;
121+
def : WriteRes<WriteFAdd64, [RocketUnitFPALU]>;
122122
def : WriteRes<WriteFSGNJ64, [RocketUnitFPALU]>;
123123
def : WriteRes<WriteFMinMax64, [RocketUnitFPALU]>;
124124
}
@@ -203,11 +203,11 @@ def : ReadAdvance<ReadAtomicSTW, 0>;
203203
def : ReadAdvance<ReadAtomicSTD, 0>;
204204
def : ReadAdvance<ReadFStoreData, 0>;
205205
def : ReadAdvance<ReadFMemBase, 0>;
206-
def : ReadAdvance<ReadFALU32, 0>;
207-
def : ReadAdvance<ReadFALU64, 0>;
206+
def : ReadAdvance<ReadFAdd32, 0>;
207+
def : ReadAdvance<ReadFAdd64, 0>;
208208
def : ReadAdvance<ReadFMul32, 0>;
209-
def : ReadAdvance<ReadFMA32, 0>;
210209
def : ReadAdvance<ReadFMul64, 0>;
210+
def : ReadAdvance<ReadFMA32, 0>;
211211
def : ReadAdvance<ReadFMA64, 0>;
212212
def : ReadAdvance<ReadFDiv32, 0>;
213213
def : ReadAdvance<ReadFDiv64, 0>;

llvm/lib/Target/RISCV/RISCVSchedSiFive7.td

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def : WriteRes<WriteAtomicLDD, [SiFive7PipeA]>;
104104

105105
// Single precision.
106106
let Latency = 5 in {
107-
def : WriteRes<WriteFALU32, [SiFive7PipeB]>;
107+
def : WriteRes<WriteFAdd32, [SiFive7PipeB]>;
108108
def : WriteRes<WriteFMul32, [SiFive7PipeB]>;
109109
def : WriteRes<WriteFMA32, [SiFive7PipeB]>;
110110
}
@@ -120,7 +120,7 @@ def : WriteRes<WriteFSqrt32, [SiFive7PipeB, SiFive7FDiv]> { let Latency = 27;
120120

121121
// Double precision
122122
let Latency = 7 in {
123-
def : WriteRes<WriteFALU64, [SiFive7PipeB]>;
123+
def : WriteRes<WriteFAdd64, [SiFive7PipeB]>;
124124
def : WriteRes<WriteFMul64, [SiFive7PipeB]>;
125125
def : WriteRes<WriteFMA64, [SiFive7PipeB]>;
126126
}
@@ -190,11 +190,11 @@ def : ReadAdvance<ReadAtomicSTW, 0>;
190190
def : ReadAdvance<ReadAtomicSTD, 0>;
191191
def : ReadAdvance<ReadFStoreData, 0>;
192192
def : ReadAdvance<ReadFMemBase, 0>;
193-
def : ReadAdvance<ReadFALU32, 0>;
194-
def : ReadAdvance<ReadFALU64, 0>;
193+
def : ReadAdvance<ReadFAdd32, 0>;
194+
def : ReadAdvance<ReadFAdd64, 0>;
195195
def : ReadAdvance<ReadFMul32, 0>;
196-
def : ReadAdvance<ReadFMA32, 0>;
197196
def : ReadAdvance<ReadFMul64, 0>;
197+
def : ReadAdvance<ReadFMA32, 0>;
198198
def : ReadAdvance<ReadFMA64, 0>;
199199
def : ReadAdvance<ReadFDiv32, 0>;
200200
def : ReadAdvance<ReadFDiv64, 0>;

llvm/lib/Target/RISCV/RISCVSchedule.td

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ def WriteAtomicLDW : SchedWrite; // Atomic load word
3838
def WriteAtomicLDD : SchedWrite; // Atomic load double word
3939
def WriteAtomicSTW : SchedWrite; // Atomic store word
4040
def WriteAtomicSTD : SchedWrite; // Atomic store double word
41-
def WriteFALU16 : SchedWrite; // FP 16-bit computation
42-
def WriteFALU32 : SchedWrite; // FP 32-bit computation
43-
def WriteFALU64 : SchedWrite; // FP 64-bit computation
41+
def WriteFAdd16 : SchedWrite; // 16-bit floating point addition/subtraction
42+
def WriteFAdd32 : SchedWrite; // 32-bit floating point addition/subtraction
43+
def WriteFAdd64 : SchedWrite; // 64-bit floating point addition/subtraction
4444
def WriteFMul16 : SchedWrite; // 16-bit floating point multiply
45-
def WriteFMA16 : SchedWrite; // 16-bit floating point fused multiply-add
4645
def WriteFMul32 : SchedWrite; // 32-bit floating point multiply
47-
def WriteFMA32 : SchedWrite; // 32-bit floating point fused multiply-add
4846
def WriteFMul64 : SchedWrite; // 64-bit floating point multiply
47+
def WriteFMA16 : SchedWrite; // 16-bit floating point fused multiply-add
48+
def WriteFMA32 : SchedWrite; // 32-bit floating point fused multiply-add
4949
def WriteFMA64 : SchedWrite; // 64-bit floating point fused multiply-add
5050
def WriteFDiv16 : SchedWrite; // 16-bit floating point divide
5151
def WriteFDiv32 : SchedWrite; // 32-bit floating point divide
@@ -131,14 +131,14 @@ def ReadAtomicLDW : SchedRead; // Atomic load word
131131
def ReadAtomicLDD : SchedRead; // Atomic load double word
132132
def ReadAtomicSTW : SchedRead; // Atomic store word
133133
def ReadAtomicSTD : SchedRead; // Atomic store double word
134-
def ReadFALU16 : SchedRead; // FP 16-bit computation
135-
def ReadFALU32 : SchedRead; // FP 32-bit computation
136-
def ReadFALU64 : SchedRead; // FP 64-bit computation
134+
def ReadFAdd16 : SchedRead; // 16-bit floating point addition/subtraction
135+
def ReadFAdd32 : SchedRead; // 32-bit floating point addition/subtraction
136+
def ReadFAdd64 : SchedRead; // 64-bit floating point addition/subtraction
137137
def ReadFMul16 : SchedRead; // 16-bit floating point multiply
138-
def ReadFMA16 : SchedRead; // 16-bit floating point fused multiply-add
139138
def ReadFMul32 : SchedRead; // 32-bit floating point multiply
140-
def ReadFMA32 : SchedRead; // 32-bit floating point fused multiply-add
141139
def ReadFMul64 : SchedRead; // 64-bit floating point multiply
140+
def ReadFMA16 : SchedRead; // 16-bit floating point fused multiply-add
141+
def ReadFMA32 : SchedRead; // 32-bit floating point fused multiply-add
142142
def ReadFMA64 : SchedRead; // 64-bit floating point fused multiply-add
143143
def ReadFDiv16 : SchedRead; // 16-bit floating point divide
144144
def ReadFDiv32 : SchedRead; // 32-bit floating point divide
@@ -185,7 +185,7 @@ def ReadFClass64 : SchedRead;
185185

186186
multiclass UnsupportedSchedZfh {
187187
let Unsupported = true in {
188-
def : WriteRes<WriteFALU16, []>;
188+
def : WriteRes<WriteFAdd16, []>;
189189
def : WriteRes<WriteFClass16, []>;
190190
def : WriteRes<WriteFCvtF16ToF64, []>;
191191
def : WriteRes<WriteFCvtF64ToF16, []>;
@@ -207,7 +207,7 @@ def : WriteRes<WriteFSGNJ16, []>;
207207
def : WriteRes<WriteFST16, []>;
208208
def : WriteRes<WriteFSqrt16, []>;
209209

210-
def : ReadAdvance<ReadFALU16, 0>;
210+
def : ReadAdvance<ReadFAdd16, 0>;
211211
def : ReadAdvance<ReadFClass16, 0>;
212212
def : ReadAdvance<ReadFCvtF16ToF64, 0>;
213213
def : ReadAdvance<ReadFCvtF64ToF16, 0>;

0 commit comments

Comments
 (0)