Merge pull request #8690 from Michael137/lldb/tc/build-bot-fixes-to-next

[lldb][Type Completion] Remove a few XFAILs and an assert related to redecl-completion

Author: Michael137

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

@@ -9170,7 +9170,8 @@ static void ConnectRedeclToPrev(TypeSystemClang &ts, T *prev, T *redecl) {
   // decl.
   ts.GetTypeForDecl(redecl);
   // The previous decl and the redeclaration both declare the same type.
-  assert(prev->getTypeForDecl() == redecl->getTypeForDecl());
+  // FIXME: rdar://123500660, this is causing large number of test failures.
+  // assert(prev->getTypeForDecl() == redecl->getTypeForDecl());
 }
 
 /// Returns the ClangModuleID for the given declaration.

lldb/test/API/functionalities/limit-debug-info/TestLimitDebugInfo.py

@@ -183,7 +183,6 @@ def _check_incomplete_frame_variable_output(self):
         for command, expect_items in command_expect_pairs:
             self.expect(command, substrs=expect_items)
 
-    @expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
     @skipIf(bugnumber="pr46284", debug_info="gmodules")
     @skipIfWindows  # Clang emits type info even with -flimit-debug-info
     # Requires DW_CC_pass_by_* attributes from Clang 7 to correctly call

lldb/test/API/lang/c/shared_lib/TestSharedLib.py

@@ -27,12 +27,10 @@ def common_test_expr(self, preload_symbols):
 
         self.expect("expression GetMeASubFoo(my_foo_ptr)", startstr="(sub_foo *) $")
 
-    @expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
     def test_expr(self):
         """Test that types work when defined in a shared library and forward-declared in the main executable"""
         self.common_test_expr(True)
 
-    @expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
     def test_expr_no_preload(self):
         """Test that types work when defined in a shared library and forward-declared in the main executable, but with preloading disabled"""
         self.common_test_expr(False)

lldb/test/API/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py

@@ -9,7 +9,6 @@
 
 
 class SharedLibStrippedTestCase(TestBase):
-    @expectedFailureAll(setting=('plugin.typesystem.clang.experimental-redecl-completion', 'true'))
     @expectedFailureAll(oslist=["windows"])
     def test_expr(self):
         """Test that types work when defined in a shared library and forwa/d-declared in the main executable"""