Skip to content

Commit d97bab6

Browse files
committed
[HWASan] Don't build alias mode on non-x86.
Alias mode is not expected work on non-x86, so don't build it there. Should fix the aarch64 bot.
1 parent 43f6e04 commit d97bab6

File tree

1 file changed

+15
-20
lines changed

1 file changed

+15
-20
lines changed

compiler-rt/lib/hwasan/CMakeLists.txt

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -93,24 +93,6 @@ add_compiler_rt_object_libraries(RTHwasan_dynamic
9393
CFLAGS ${HWASAN_DYNAMIC_CFLAGS}
9494
DEFS ${HWASAN_DEFINITIONS})
9595

96-
# Compile a different runtime for x86 aliasing mode.
97-
set(HWASAN_ALIASES_RTL_CFLAGS ${HWASAN_RTL_CFLAGS})
98-
list(APPEND HWASAN_ALIASES_RTL_CFLAGS -DHWASAN_ALIASING_MODE)
99-
set(HWASAN_ALIASES_DYNAMIC_CFLAGS ${HWASAN_DYNAMIC_CFLAGS})
100-
list(APPEND HWASAN_ALIASES_DYNAMIC_CFLAGS -DHWASAN_ALIASING_MODE)
101-
add_compiler_rt_object_libraries(RTHwasanAliases
102-
ARCHS ${HWASAN_SUPPORTED_ARCH}
103-
SOURCES ${HWASAN_RTL_SOURCES}
104-
ADDITIONAL_HEADERS ${HWASAN_RTL_HEADERS}
105-
CFLAGS ${HWASAN_ALIASES_RTL_CFLAGS}
106-
DEFS ${HWASAN_DEFINITIONS})
107-
add_compiler_rt_object_libraries(RTHwasanAliases_dynamic
108-
ARCHS ${HWASAN_SUPPORTED_ARCH}
109-
SOURCES ${HWASAN_RTL_SOURCES} ${HWASAN_RTL_CXX_SOURCES}
110-
ADDITIONAL_HEADERS ${HWASAN_RTL_HEADERS}
111-
CFLAGS ${HWASAN_ALIASES_DYNAMIC_CFLAGS}
112-
DEFS ${HWASAN_DEFINITIONS})
113-
11496
file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/dummy.cpp "")
11597
add_compiler_rt_object_libraries(RTHwasan_dynamic_version_script_dummy
11698
ARCHS ${HWASAN_SUPPORTED_ARCH}
@@ -127,11 +109,24 @@ function(add_hwasan_runtimes arch use_aliases)
127109
set(hwasan_rtl_flags ${HWASAN_RTL_CFLAGS})
128110
set(hwasan_dyn_flags ${HWASAN_DYNAMIC_CFLAGS})
129111
if(use_aliases)
112+
list(APPEND hwasan_rtl_flags -DHWASAN_ALIASING_MODE)
113+
list(APPEND hwasan_dyn_flags -DHWASAN_ALIASING_MODE)
114+
add_compiler_rt_object_libraries(RTHwasanAliases
115+
ARCHS ${arch}
116+
SOURCES ${HWASAN_RTL_SOURCES}
117+
ADDITIONAL_HEADERS ${HWASAN_RTL_HEADERS}
118+
CFLAGS ${hwasan_rtl_flags}
119+
DEFS ${HWASAN_DEFINITIONS})
120+
add_compiler_rt_object_libraries(RTHwasanAliases_dynamic
121+
ARCHS ${arch}
122+
SOURCES ${HWASAN_RTL_SOURCES} ${HWASAN_RTL_CXX_SOURCES}
123+
ADDITIONAL_HEADERS ${HWASAN_RTL_HEADERS}
124+
CFLAGS ${hwasan_dyn_flags}
125+
DEFS ${HWASAN_DEFINITIONS})
126+
130127
set(hwasan_object_lib RTHwasanAliases)
131128
set(hwasan_object_dyn_lib RTHwasanAliases_dynamic)
132129
set(hwasan_runtime clang_rt.hwasan_aliases)
133-
set(hwasan_rtl_flags ${HWASAN_ALIASES_RTL_CFLAGS})
134-
set(hwasan_dyn_flags ${HWASAN_ALIASES_DYNAMIC_CFLAGS})
135130
endif()
136131
add_compiler_rt_runtime(${hwasan_runtime}
137132
STATIC

0 commit comments

Comments
 (0)