Skip to content

Commit dd5ce50

Browse files
committed
[libcxx] [test] Remove a LIBCXX-WINDOWS-FIXME, don't test an unsupported strftime() pattern
Testing the unsupported pattern can trigger the invalid parameter handler, which depending on CRT configuration can abort the process. Differential Revision: https://reviews.llvm.org/D112352
1 parent ae31f9f commit dd5ce50

File tree

1 file changed

+4
-2
lines changed
  • libcxx/test/std/localization/locale.categories/category.time/locale.time.put/locale.time.put.members

1 file changed

+4
-2
lines changed

libcxx/test/std/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// XFAIL: LIBCXX-WINDOWS-FIXME
10-
119
// <locale>
1210

1311
// class time_put<charT, OutputIterator>
@@ -321,11 +319,15 @@ int main(int, char**)
321319
std::string ex(str, iter.base());
322320
// assert(ex == "-0400"); depends on time zone
323321
}
322+
#ifndef _WIN32
323+
// The Windows strftime() doesn't support the "%+" format. Depending on CRT
324+
// configuration of the invalid parameter handler, this can abort the process.
324325
{
325326
iter = f.put(output_iterator<char*>(str), ios, '*', &t, '+');
326327
std::string ex(str, iter.base());
327328
// assert(ex == "Sat May 2 13:03:06 EDT 2009"); depends on time zone
328329
}
330+
#endif
329331
{
330332
iter = f.put(output_iterator<char*>(str), ios, '*', &t, '%');
331333
std::string ex(str, iter.base());

0 commit comments

Comments
 (0)