Skip to content

Commit ddb0bcb

Browse files
committed
Add missing cases in RISCVMCExpr::getVariantKindName
Differential Revision: https://reviews.llvm.org/D98929
1 parent c8cf8bc commit ddb0bcb

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.cpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ RISCVMCExpr::VariantKind RISCVMCExpr::getVariantKindForName(StringRef name) {
138138

139139
StringRef RISCVMCExpr::getVariantKindName(VariantKind Kind) {
140140
switch (Kind) {
141-
default:
141+
case VK_RISCV_Invalid:
142+
case VK_RISCV_None:
142143
llvm_unreachable("Invalid ELF symbol kind");
143144
case VK_RISCV_LO:
144145
return "lo";
@@ -160,7 +161,14 @@ StringRef RISCVMCExpr::getVariantKindName(VariantKind Kind) {
160161
return "tls_ie_pcrel_hi";
161162
case VK_RISCV_TLS_GD_HI:
162163
return "tls_gd_pcrel_hi";
164+
case VK_RISCV_CALL:
165+
return "call";
166+
case VK_RISCV_CALL_PLT:
167+
return "call_plt";
168+
case VK_RISCV_32_PCREL:
169+
return "32_pcrel";
163170
}
171+
llvm_unreachable("Invalid ELF symbol kind");
164172
}
165173

166174
static void fixELFSymbolsInTLSFixupsImpl(const MCExpr *Expr, MCAssembler &Asm) {

llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class RISCVMCExpr : public MCTargetExpr {
3737
VK_RISCV_CALL,
3838
VK_RISCV_CALL_PLT,
3939
VK_RISCV_32_PCREL,
40-
VK_RISCV_Invalid
40+
VK_RISCV_Invalid // Must be the last item
4141
};
4242

4343
private:

0 commit comments

Comments
 (0)