Merge pull request #3341 from apple/lldb-Pass-extra-clang-args-by-const-ref-NFC

kastiglione · web-flow · commit e091babd4f0e · 2021-10-05T08:46:21.000-07:00
[lldb] Pass extra clang args by const-ref (NFC)
diff --git a/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp b/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp
@@ -1502,7 +1502,7 @@ void SwiftASTContext::AddExtraClangArgs(const std::vector<std::string>& source,
   }
 }
 
-void SwiftASTContext::AddExtraClangArgs(std::vector<std::string> ExtraArgs) {
+void SwiftASTContext::AddExtraClangArgs(const std::vector<std::string> &ExtraArgs) {
   swift::ClangImporterOptions &importer_options = GetClangImporterOptions();
   AddExtraClangArgs(ExtraArgs, importer_options.ExtraArgs);
 }
diff --git a/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.h b/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.h
@@ -242,7 +242,7 @@ class SwiftASTContext : public TypeSystemSwift {
 
   /// Add a list of Clang arguments to the ClangImporter options and
   /// apply the working directory to any relative paths.
-  void AddExtraClangArgs(std::vector<std::string> ExtraArgs);
+  void AddExtraClangArgs(const std::vector<std::string> &ExtraArgs);
   static void AddExtraClangArgs(const std::vector<std::string>& source,
                                 std::vector<std::string>& dest);
 

Original file line number	Diff line number	Diff line change
`@@ -1502,7 +1502,7 @@ void SwiftASTContext::AddExtraClangArgs(const std::vector<std::string>& source,`
`1502`	`1502`	`}`
`1503`	`1503`	`}`
`1504`	`1504`
`1505`		`-void SwiftASTContext::AddExtraClangArgs(std::vector<std::string> ExtraArgs) {`
	`1505`	`+void SwiftASTContext::AddExtraClangArgs(const std::vector<std::string> &ExtraArgs) {`
`1506`	`1506`	`swift::ClangImporterOptions &importer_options = GetClangImporterOptions();`
`1507`	`1507`	`AddExtraClangArgs(ExtraArgs, importer_options.ExtraArgs);`
`1508`	`1508`	`}`