Skip to content

Commit e2bdb4a

Browse files
paperchalicedanliew-apple
authored andcommitted
Revert "[Passes] Expose parseSinglePassOption" (llvm#86225)
Reverts llvm#86117 (cherry picked from commit 8d7d581)
1 parent f261b49 commit e2bdb4a

File tree

2 files changed

+24
-38
lines changed

2 files changed

+24
-38
lines changed

llvm/include/llvm/Passes/PassBuilder.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -677,13 +677,6 @@ class PassBuilder {
677677
return Result;
678678
}
679679

680-
/// Handle passes only accept one bool-valued parameter.
681-
///
682-
/// \return false when Params is empty.
683-
static Expected<bool> parseSinglePassOption(StringRef Params,
684-
StringRef OptionName,
685-
StringRef PassName);
686-
687680
private:
688681
// O1 pass pipeline
689682
FunctionPassManager

llvm/lib/Passes/PassBuilder.cpp

Lines changed: 24 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -601,9 +601,8 @@ Expected<LoopUnrollOptions> parseLoopUnrollOptions(StringRef Params) {
601601
return UnrollOpts;
602602
}
603603

604-
Expected<bool> PassBuilder::parseSinglePassOption(StringRef Params,
605-
StringRef OptionName,
606-
StringRef PassName) {
604+
Expected<bool> parseSinglePassOption(StringRef Params, StringRef OptionName,
605+
StringRef PassName) {
607606
bool Result = false;
608607
while (!Params.empty()) {
609608
StringRef ParamName;
@@ -622,28 +621,24 @@ Expected<bool> PassBuilder::parseSinglePassOption(StringRef Params,
622621
}
623622

624623
Expected<bool> parseGlobalDCEPassOptions(StringRef Params) {
625-
return PassBuilder::parseSinglePassOption(
626-
Params, "vfe-linkage-unit-visibility", "GlobalDCE");
624+
return parseSinglePassOption(Params, "vfe-linkage-unit-visibility", "GlobalDCE");
627625
}
628626

629627
Expected<bool> parseCGProfilePassOptions(StringRef Params) {
630-
return PassBuilder::parseSinglePassOption(Params, "in-lto-post-link",
631-
"CGProfile");
628+
return parseSinglePassOption(Params, "in-lto-post-link", "CGProfile");
632629
}
633630

634631
Expected<bool> parseInlinerPassOptions(StringRef Params) {
635-
return PassBuilder::parseSinglePassOption(Params, "only-mandatory",
636-
"InlinerPass");
632+
return parseSinglePassOption(Params, "only-mandatory", "InlinerPass");
637633
}
638634

639635
Expected<bool> parseCoroSplitPassOptions(StringRef Params) {
640-
return PassBuilder::parseSinglePassOption(Params, "reuse-storage",
641-
"CoroSplitPass");
636+
return parseSinglePassOption(Params, "reuse-storage", "CoroSplitPass");
642637
}
643638

644639
Expected<bool> parsePostOrderFunctionAttrsPassOptions(StringRef Params) {
645-
return PassBuilder::parseSinglePassOption(
646-
Params, "skip-non-recursive-function-attrs", "PostOrderFunctionAttrs");
640+
return parseSinglePassOption(Params, "skip-non-recursive-function-attrs",
641+
"PostOrderFunctionAttrs");
647642
}
648643

649644
Expected<CFGuardPass::Mechanism> parseCFGuardPassOptions(StringRef Params) {
@@ -667,21 +662,19 @@ Expected<CFGuardPass::Mechanism> parseCFGuardPassOptions(StringRef Params) {
667662
}
668663

669664
Expected<bool> parseEarlyCSEPassOptions(StringRef Params) {
670-
return PassBuilder::parseSinglePassOption(Params, "memssa", "EarlyCSE");
665+
return parseSinglePassOption(Params, "memssa", "EarlyCSE");
671666
}
672667

673668
Expected<bool> parseEntryExitInstrumenterPassOptions(StringRef Params) {
674-
return PassBuilder::parseSinglePassOption(Params, "post-inline",
675-
"EntryExitInstrumenter");
669+
return parseSinglePassOption(Params, "post-inline", "EntryExitInstrumenter");
676670
}
677671

678672
Expected<bool> parseLoopExtractorPassOptions(StringRef Params) {
679-
return PassBuilder::parseSinglePassOption(Params, "single", "LoopExtractor");
673+
return parseSinglePassOption(Params, "single", "LoopExtractor");
680674
}
681675

682676
Expected<bool> parseLowerMatrixIntrinsicsPassOptions(StringRef Params) {
683-
return PassBuilder::parseSinglePassOption(Params, "minimal",
684-
"LowerMatrixIntrinsics");
677+
return parseSinglePassOption(Params, "minimal", "LowerMatrixIntrinsics");
685678
}
686679

687680
Expected<AddressSanitizerOptions> parseASanPassOptions(StringRef Params) {
@@ -1021,13 +1014,13 @@ parseStackLifetimeOptions(StringRef Params) {
10211014
}
10221015

10231016
Expected<bool> parseDependenceAnalysisPrinterOptions(StringRef Params) {
1024-
return PassBuilder::parseSinglePassOption(Params, "normalized-results",
1025-
"DependenceAnalysisPrinter");
1017+
return parseSinglePassOption(Params, "normalized-results",
1018+
"DependenceAnalysisPrinter");
10261019
}
10271020

10281021
Expected<bool> parseSeparateConstOffsetFromGEPPassOptions(StringRef Params) {
1029-
return PassBuilder::parseSinglePassOption(Params, "lower-gep",
1030-
"SeparateConstOffsetFromGEP");
1022+
return parseSinglePassOption(Params, "lower-gep",
1023+
"SeparateConstOffsetFromGEP");
10311024
}
10321025

10331026
Expected<OptimizationLevel>
@@ -1043,13 +1036,13 @@ parseFunctionSimplificationPipelineOptions(StringRef Params) {
10431036
}
10441037

10451038
Expected<bool> parseMemorySSAPrinterPassOptions(StringRef Params) {
1046-
return PassBuilder::parseSinglePassOption(Params, "no-ensure-optimized-uses",
1047-
"MemorySSAPrinterPass");
1039+
return parseSinglePassOption(Params, "no-ensure-optimized-uses",
1040+
"MemorySSAPrinterPass");
10481041
}
10491042

10501043
Expected<bool> parseSpeculativeExecutionPassOptions(StringRef Params) {
1051-
return PassBuilder::parseSinglePassOption(Params, "only-if-divergent-target",
1052-
"SpeculativeExecutionPass");
1044+
return parseSinglePassOption(Params, "only-if-divergent-target",
1045+
"SpeculativeExecutionPass");
10531046
}
10541047

10551048
Expected<std::string> parseMemProfUsePassOptions(StringRef Params) {
@@ -1070,13 +1063,13 @@ Expected<std::string> parseMemProfUsePassOptions(StringRef Params) {
10701063
}
10711064

10721065
Expected<bool> parseStructuralHashPrinterPassOptions(StringRef Params) {
1073-
return PassBuilder::parseSinglePassOption(Params, "detailed",
1074-
"StructuralHashPrinterPass");
1066+
return parseSinglePassOption(Params, "detailed",
1067+
"StructuralHashPrinterPass");
10751068
}
10761069

10771070
Expected<bool> parseWinEHPrepareOptions(StringRef Params) {
1078-
return PassBuilder::parseSinglePassOption(Params, "demote-catchswitch-only",
1079-
"WinEHPreparePass");
1071+
return parseSinglePassOption(Params, "demote-catchswitch-only",
1072+
"WinEHPreparePass");
10801073
}
10811074

10821075
Expected<GlobalMergeOptions> parseGlobalMergeOptions(StringRef Params) {

0 commit comments

Comments
 (0)