Skip to content

Commit ea28668

Browse files
authored
[mlir][ArmSME] Remove XFAILs (llvm#104758)
Buildbots have been updated to QEMU 9.0.2: llvm#104758 (comment)
1 parent 7efa068 commit ea28668

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/multi-tile-matmul-mixed-types.mlir

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,8 @@
1313
/// tests a mixed i8 to i32 matmul and outer product fusion which fuses 16
1414
/// outer products (four per tile) into four 4-way outer products.
1515

16-
/// NOTE: QEMU gives incorrect result for SME SMOPA 4-way outer product
17-
/// instruction (version <= 8.2.0, latest version at time of writing), see:
18-
/// https://gitlab.com/qemu-project/qemu/-/issues/2083
19-
/// This test is expected to fail until a fixed version of QEMU can be used.
20-
21-
/// FIXME: Remove the 'XFAIL' below once a fixed QEMU version is available
22-
/// (and installed on CI buildbot).
23-
/// XFAIL: *
16+
// NOTE: QEMU <= 8.2.0 gives incorrect result for SME SMOPA 4-way outer product
17+
// instruction see: https://gitlab.com/qemu-project/qemu/-/issues/2083.
2418

2519
func.func @matmul_i8_to_i32(%A : tensor<?x?xi8>, %B : tensor<?x?xi8>, %C : tensor<?x?xi32>) {
2620
%res = linalg.matmul ins(%A, %B: tensor<?x?xi8>, tensor<?x?xi8>)

mlir/test/Integration/Dialect/Vector/CPU/ArmSME/outerproduct-i8i8i32.mlir

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,8 @@
77

88
// RUN: %{compile} | %{run} | FileCheck %s
99

10-
// NOTE: QEMU gives incorrect result for SME SMOPA 4-way outer product
11-
// instruction (version <= 8.2.0, latest version at time of writing), see:
12-
// https://gitlab.com/qemu-project/qemu/-/issues/2083 This test is expected to
13-
// fail (CHECK lines are correct) until a fixed version of QEMU can be used.
14-
15-
// FIXME: Remove the 'XFAIL' below once a fixed QEMU version is available
16-
// (and installed on CI buildbot).
17-
// XFAIL: *
10+
// NOTE: QEMU <= 8.2.0 gives incorrect result for SME SMOPA 4-way outer product
11+
// instruction see: https://gitlab.com/qemu-project/qemu/-/issues/2083.
1812

1913
// NOTE: there is no non-widening variant for these types and this test can't
2014
// be lowered without the widening pass, therefore we can't check if the result

0 commit comments

Comments
 (0)