Skip to content

Commit ea9539e

Browse files
committed
Hoist SwiftASTContext::GetMinimumLanguage() into TypeSystemSwift (NFC)
(cherry picked from commit 96c0a0d)
1 parent baa5414 commit ea9539e

File tree

6 files changed

+15
-17
lines changed

6 files changed

+15
-17
lines changed

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5497,14 +5497,6 @@ SwiftASTContext::GetTypeInfo(opaque_compiler_type_t type,
54975497
return swift_flags;
54985498
}
54995499

5500-
lldb::LanguageType
5501-
SwiftASTContext::GetMinimumLanguage(opaque_compiler_type_t type) {
5502-
if (!type)
5503-
return lldb::eLanguageTypeC;
5504-
5505-
return lldb::eLanguageTypeSwift;
5506-
}
5507-
55085500
lldb::TypeClass SwiftASTContext::GetTypeClass(opaque_compiler_type_t type) {
55095501
VALID_OR_RETURN(lldb::eTypeClassInvalid);
55105502

lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,6 @@ class SwiftASTContext : public TypeSystemSwift {
525525
uint32_t GetTypeInfo(lldb::opaque_compiler_type_t type,
526526
CompilerType *pointee_or_element_clang_type) override;
527527

528-
lldb::LanguageType
529-
GetMinimumLanguage(lldb::opaque_compiler_type_t type) override;
530-
531528
lldb::TypeClass GetTypeClass(lldb::opaque_compiler_type_t type) override;
532529

533530
// Creating related types

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwift.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,10 @@ class TypeSystemSwift : public TypeSystem {
177177
// TestSwiftStepping were failing because of this Darwin.
178178
return false;
179179
}
180+
lldb::LanguageType
181+
GetMinimumLanguage(lldb::opaque_compiler_type_t type) override {
182+
return lldb::eLanguageTypeSwift;
183+
}
180184
unsigned GetTypeQualifiers(lldb::opaque_compiler_type_t type) override {
181185
return 0;
182186
}

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1457,10 +1457,6 @@ uint32_t TypeSystemSwiftTypeRef::GetTypeInfo(
14571457
VALIDATE_AND_RETURN(impl, GetTypeInfo, type,
14581458
(ReconstructType(type), nullptr));
14591459
}
1460-
lldb::LanguageType
1461-
TypeSystemSwiftTypeRef::GetMinimumLanguage(opaque_compiler_type_t type) {
1462-
return m_swift_ast_context->GetMinimumLanguage(ReconstructType(type));
1463-
}
14641460
lldb::TypeClass
14651461
TypeSystemSwiftTypeRef::GetTypeClass(opaque_compiler_type_t type) {
14661462
return m_swift_ast_context->GetTypeClass(ReconstructType(type));

lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,6 @@ class TypeSystemSwiftTypeRef : public TypeSystemSwift {
110110
ConstString GetMangledTypeName(lldb::opaque_compiler_type_t type) override;
111111
uint32_t GetTypeInfo(lldb::opaque_compiler_type_t type,
112112
CompilerType *pointee_or_element_clang_type) override;
113-
lldb::LanguageType
114-
GetMinimumLanguage(lldb::opaque_compiler_type_t type) override;
115113
lldb::TypeClass GetTypeClass(lldb::opaque_compiler_type_t type) override;
116114

117115
// Creating related types

lldb/unittests/Symbol/TestTypeSystemSwiftTypeRef.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,3 +346,14 @@ TEST_F(TestTypeSystemSwiftTypeRef, ScalarAddress) {
346346
ASSERT_TRUE(c.ShouldTreatScalarValueAsAddress());
347347
}
348348
}
349+
350+
TEST_F(TestTypeSystemSwiftTypeRef, LanguageVersion) {
351+
using namespace swift::Demangle;
352+
Demangler dem;
353+
NodeBuilder b(dem);
354+
{
355+
NodePointer int_node = b.GlobalTypeMangling(b.IntType());
356+
CompilerType int_type = GetCompilerType(b.Mangle(int_node));
357+
ASSERT_EQ(int_type.GetMinimumLanguage(), lldb::eLanguageTypeSwift);
358+
}
359+
}

0 commit comments

Comments
 (0)