Skip to content

Commit edbb0f6

Browse files
committed
[lldb] Rename DemangleWithRichManglingInfo to GetRichManglingInfo (NFC)
This addresses Pavel's comment from D118814.
1 parent b4be182 commit edbb0f6

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

lldb/include/lldb/Core/Mangled.h

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,9 @@ class Mangled {
226226
/// Function signature for filtering mangled names.
227227
using SkipMangledNameFn = bool(llvm::StringRef, ManglingScheme);
228228

229-
/// Trigger explicit demangling to obtain rich mangling information. This is
230-
/// optimized for batch processing while populating a name index. To get the
231-
/// pure demangled name string for a single entity, use GetDemangledName()
232-
/// instead.
229+
/// Get rich mangling information. This is optimized for batch processing
230+
/// while populating a name index. To get the pure demangled name string for
231+
/// a single entity, use GetDemangledName() instead.
233232
///
234233
/// For names that match the Itanium mangling scheme, this uses LLVM's
235234
/// ItaniumPartialDemangler. All other names fall back to LLDB's builtin
@@ -248,8 +247,8 @@ class Mangled {
248247
///
249248
/// \return
250249
/// True on success, false otherwise.
251-
bool DemangleWithRichManglingInfo(RichManglingContext &context,
252-
SkipMangledNameFn *skip_mangled_name);
250+
bool GetRichManglingInfo(RichManglingContext &context,
251+
SkipMangledNameFn *skip_mangled_name);
253252

254253
/// Try to identify the mangling scheme used.
255254
/// \param[in] name

lldb/source/Core/Mangled.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@ static char *GetDLangDemangledStr(const char *M) {
195195

196196
// Explicit demangling for scheduled requests during batch processing. This
197197
// makes use of ItaniumPartialDemangler's rich demangle info
198-
bool Mangled::DemangleWithRichManglingInfo(
199-
RichManglingContext &context, SkipMangledNameFn *skip_mangled_name) {
198+
bool Mangled::GetRichManglingInfo(RichManglingContext &context,
199+
SkipMangledNameFn *skip_mangled_name) {
200200
// Others are not meant to arrive here. ObjC names or C's main() for example
201201
// have their names stored in m_demangled, while m_mangled is empty.
202202
assert(m_mangled);

lldb/source/Symbol/Symtab.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ void Symtab::InitNameIndexes() {
328328

329329
const SymbolType type = symbol->GetType();
330330
if (type == eSymbolTypeCode || type == eSymbolTypeResolver) {
331-
if (mangled.DemangleWithRichManglingInfo(rmc, lldb_skip_name)) {
331+
if (mangled.GetRichManglingInfo(rmc, lldb_skip_name)) {
332332
RegisterMangledNameEntry(value, class_contexts, backlog, rmc);
333333
continue;
334334
}

0 commit comments

Comments
 (0)