Skip to content

Commit f45c65a

Browse files
jayfoadjayfoad
committed
Revert "[IR] Clean up dead instructions after simplifying a conditional branch"
This reverts commit 4494e45. It caused problems for sanitizer buildbots.
1 parent bb8c7e7 commit f45c65a

File tree

4 files changed

+73
-88
lines changed

4 files changed

+73
-88
lines changed

‎llvm/include/llvm/IR/BasicBlock.h

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "llvm/IR/Instruction.h"
2323
#include "llvm/IR/SymbolTableListTraits.h"
2424
#include "llvm/IR/Value.h"
25-
#include "llvm/IR/ValueHandle.h"
2625
#include "llvm/Support/CBindingWrapping.h"
2726
#include "llvm/Support/Casting.h"
2827
#include "llvm/Support/Compiler.h"
@@ -377,13 +376,7 @@ class BasicBlock final : public Value, // Basic blocks are data objects also
377376
/// If \p KeepOneInputPHIs is true then don't remove PHIs that are left with
378377
/// zero or one incoming values, and don't simplify PHIs with all incoming
379378
/// values the same.
380-
///
381-
/// If \p MaybeDeadInstrs is not nullptr then whenever we drop a reference to
382-
/// an instruction, append it to the vector. The caller should check whether
383-
/// these instructions are now trivially dead, and if so delete them.
384-
void
385-
removePredecessor(BasicBlock *Pred, bool KeepOneInputPHIs = false,
386-
SmallVectorImpl<WeakTrackingVH> *MaybeDeadInstrs = nullptr);
379+
void removePredecessor(BasicBlock *Pred, bool KeepOneInputPHIs = false);
387380

388381
bool canSplitPredecessors() const;
389382

‎llvm/lib/IR/BasicBlock.cpp

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -323,13 +323,8 @@ iterator_range<BasicBlock::phi_iterator> BasicBlock::phis() {
323323
/// If \p KeepOneInputPHIs is true then don't remove PHIs that are left with
324324
/// zero or one incoming values, and don't simplify PHIs with all incoming
325325
/// values the same.
326-
///
327-
/// If \p MaybeDeadInstrs is not nullptr then whenever we drop a reference to
328-
/// an instruction, append it to the vector. The caller should check whether
329-
/// these instructions are now trivially dead, and if so delete them.
330-
void BasicBlock::removePredecessor(
331-
BasicBlock *Pred, bool KeepOneInputPHIs,
332-
SmallVectorImpl<WeakTrackingVH> *MaybeDeadInstrs) {
326+
void BasicBlock::removePredecessor(BasicBlock *Pred,
327+
bool KeepOneInputPHIs) {
333328
// Use hasNUsesOrMore to bound the cost of this assertion for complex CFGs.
334329
assert((hasNUsesOrMore(16) ||
335330
find(pred_begin(this), pred_end(this), Pred) != pred_end(this)) &&
@@ -343,11 +338,7 @@ void BasicBlock::removePredecessor(
343338
// Update all PHI nodes.
344339
for (iterator II = begin(); isa<PHINode>(II);) {
345340
PHINode *PN = cast<PHINode>(II++);
346-
Value *V = PN->removeIncomingValue(Pred);
347-
if (MaybeDeadInstrs) {
348-
if (auto *I = dyn_cast<Instruction>(V))
349-
MaybeDeadInstrs->push_back(I);
350-
}
341+
PN->removeIncomingValue(Pred, !KeepOneInputPHIs);
351342
if (!KeepOneInputPHIs) {
352343
// If we have a single predecessor, removeIncomingValue erased the PHI
353344
// node itself.

‎llvm/lib/Transforms/Utils/Local.cpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,8 @@ bool llvm::ConstantFoldTerminator(BasicBlock *BB, bool DeleteDeadConditions,
126126
BasicBlock *OldDest = Cond->getZExtValue() ? Dest2 : Dest1;
127127

128128
// Let the basic block know that we are letting go of it. Based on this,
129-
// it will adjust its PHI nodes.
130-
SmallVector<WeakTrackingVH, 8> MaybeDeadInstrs;
131-
OldDest->removePredecessor(BB, false, &MaybeDeadInstrs);
132-
RecursivelyDeleteTriviallyDeadInstructionsPermissive(MaybeDeadInstrs,
133-
TLI);
129+
// it will adjust it's PHI nodes.
130+
OldDest->removePredecessor(BB);
134131

135132
// Replace the conditional branch with an unconditional one.
136133
Builder.CreateBr(Destination);
@@ -473,8 +470,8 @@ bool llvm::RecursivelyDeleteTriviallyDeadInstructionsPermissive(
473470
MemorySSAUpdater *MSSAU) {
474471
unsigned S = 0, E = DeadInsts.size(), Alive = 0;
475472
for (; S != E; ++S) {
476-
auto *I = dyn_cast<Instruction>(DeadInsts[S]);
477-
if (!I || !isInstructionTriviallyDead(I)) {
473+
auto *I = cast<Instruction>(DeadInsts[S]);
474+
if (!isInstructionTriviallyDead(I)) {
478475
DeadInsts[S] = nullptr;
479476
++Alive;
480477
}

‎llvm/test/Transforms/PGOProfile/chr.ll

Lines changed: 65 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -448,33 +448,34 @@ define i32 @test_chr_5(i32* %i, i32 %sum0) !prof !14 {
448448
; CHECK-NEXT: [[TMP0:%.*]] = load i32, i32* [[I:%.*]], align 4
449449
; CHECK-NEXT: [[TMP1:%.*]] = and i32 [[TMP0]], 15
450450
; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i32 [[TMP1]], 15
451-
; CHECK-NEXT: br i1 [[TMP2]], label [[BB1:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
452-
; CHECK: bb1:
453-
; CHECK-NEXT: [[TMP3:%.*]] = add i32 [[SUM0:%.*]], 173
451+
; CHECK-NEXT: br i1 [[TMP2]], label [[BB0:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
452+
; CHECK: bb0:
453+
; CHECK-NEXT: [[TMP3:%.*]] = add i32 [[SUM0:%.*]], 85
454+
; CHECK-NEXT: [[TMP4:%.*]] = add i32 [[SUM0]], 173
454455
; CHECK-NEXT: br label [[BB3:%.*]]
455456
; CHECK: entry.split.nonchr:
456-
; CHECK-NEXT: [[TMP4:%.*]] = and i32 [[TMP0]], 255
457-
; CHECK-NEXT: [[TMP5:%.*]] = icmp eq i32 [[TMP4]], 0
458-
; CHECK-NEXT: br i1 [[TMP5]], label [[BB3]], label [[BB0_NONCHR:%.*]], !prof !16
457+
; CHECK-NEXT: [[TMP5:%.*]] = and i32 [[TMP0]], 255
458+
; CHECK-NEXT: [[TMP6:%.*]] = icmp eq i32 [[TMP5]], 0
459+
; CHECK-NEXT: br i1 [[TMP6]], label [[BB3]], label [[BB0_NONCHR:%.*]], !prof !16
459460
; CHECK: bb0.nonchr:
460-
; CHECK-NEXT: [[TMP6:%.*]] = and i32 [[TMP0]], 1
461-
; CHECK-NEXT: [[TMP7:%.*]] = icmp eq i32 [[TMP6]], 0
462-
; CHECK-NEXT: [[TMP8:%.*]] = add i32 [[SUM0]], 42
463-
; CHECK-NEXT: [[SUM1_NONCHR:%.*]] = select i1 [[TMP7]], i32 [[SUM0]], i32 [[TMP8]], !prof !16
464-
; CHECK-NEXT: [[TMP9:%.*]] = and i32 [[TMP0]], 2
465-
; CHECK-NEXT: [[TMP10:%.*]] = icmp eq i32 [[TMP9]], 0
466-
; CHECK-NEXT: [[TMP11:%.*]] = add i32 [[SUM1_NONCHR]], 43
467-
; CHECK-NEXT: [[SUM2_NONCHR:%.*]] = select i1 [[TMP10]], i32 [[SUM1_NONCHR]], i32 [[TMP11]], !prof !16
468-
; CHECK-NEXT: [[TMP12:%.*]] = and i32 [[TMP0]], 4
469-
; CHECK-NEXT: [[TMP13:%.*]] = icmp eq i32 [[TMP12]], 0
470-
; CHECK-NEXT: [[TMP14:%.*]] = and i32 [[TMP0]], 8
471-
; CHECK-NEXT: [[TMP15:%.*]] = icmp eq i32 [[TMP14]], 0
472-
; CHECK-NEXT: [[SUM4_NONCHR_V:%.*]] = select i1 [[TMP15]], i32 44, i32 88
461+
; CHECK-NEXT: [[TMP7:%.*]] = and i32 [[TMP0]], 1
462+
; CHECK-NEXT: [[TMP8:%.*]] = icmp eq i32 [[TMP7]], 0
463+
; CHECK-NEXT: [[TMP9:%.*]] = add i32 [[SUM0]], 42
464+
; CHECK-NEXT: [[SUM1_NONCHR:%.*]] = select i1 [[TMP8]], i32 [[SUM0]], i32 [[TMP9]], !prof !16
465+
; CHECK-NEXT: [[TMP10:%.*]] = and i32 [[TMP0]], 2
466+
; CHECK-NEXT: [[TMP11:%.*]] = icmp eq i32 [[TMP10]], 0
467+
; CHECK-NEXT: [[TMP12:%.*]] = add i32 [[SUM1_NONCHR]], 43
468+
; CHECK-NEXT: [[SUM2_NONCHR:%.*]] = select i1 [[TMP11]], i32 [[SUM1_NONCHR]], i32 [[TMP12]], !prof !16
469+
; CHECK-NEXT: [[TMP13:%.*]] = and i32 [[TMP0]], 4
470+
; CHECK-NEXT: [[TMP14:%.*]] = icmp eq i32 [[TMP13]], 0
471+
; CHECK-NEXT: [[TMP15:%.*]] = and i32 [[TMP0]], 8
472+
; CHECK-NEXT: [[TMP16:%.*]] = icmp eq i32 [[TMP15]], 0
473+
; CHECK-NEXT: [[SUM4_NONCHR_V:%.*]] = select i1 [[TMP16]], i32 44, i32 88
473474
; CHECK-NEXT: [[SUM4_NONCHR:%.*]] = add i32 [[SUM2_NONCHR]], [[SUM4_NONCHR_V]]
474-
; CHECK-NEXT: [[SUM5_NONCHR:%.*]] = select i1 [[TMP13]], i32 [[SUM2_NONCHR]], i32 [[SUM4_NONCHR]], !prof !16
475+
; CHECK-NEXT: [[SUM5_NONCHR:%.*]] = select i1 [[TMP14]], i32 [[SUM2_NONCHR]], i32 [[SUM4_NONCHR]], !prof !16
475476
; CHECK-NEXT: br label [[BB3]]
476477
; CHECK: bb3:
477-
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[TMP3]], [[BB1]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
478+
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[TMP4]], [[BB0]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
478479
; CHECK-NEXT: ret i32 [[SUM6]]
479480
;
480481
entry:
@@ -547,33 +548,34 @@ define i32 @test_chr_5_1(i32* %i, i32 %sum0) !prof !14 {
547548
; CHECK-NEXT: [[TMP3:%.*]] = and i32 [[TMP0]], 11
548549
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 11
549550
; CHECK-NEXT: [[TMP5:%.*]] = and i1 [[TMP4]], [[TMP2]]
550-
; CHECK-NEXT: br i1 [[TMP5]], label [[BB1:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
551-
; CHECK: bb1:
552-
; CHECK-NEXT: [[TMP6:%.*]] = add i32 [[SUM0]], 173
551+
; CHECK-NEXT: br i1 [[TMP5]], label [[BB0:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
552+
; CHECK: bb0:
553+
; CHECK-NEXT: [[TMP6:%.*]] = add i32 [[SUM0]], 85
554+
; CHECK-NEXT: [[TMP7:%.*]] = add i32 [[SUM0]], 173
553555
; CHECK-NEXT: br label [[BB3:%.*]]
554556
; CHECK: entry.split.nonchr:
555-
; CHECK-NEXT: [[TMP7:%.*]] = and i32 [[TMP0]], 255
556-
; CHECK-NEXT: [[TMP8:%.*]] = icmp eq i32 [[TMP7]], 0
557-
; CHECK-NEXT: br i1 [[TMP8]], label [[BB3]], label [[BB0_NONCHR:%.*]], !prof !16
557+
; CHECK-NEXT: [[TMP8:%.*]] = and i32 [[TMP0]], 255
558+
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
559+
; CHECK-NEXT: br i1 [[TMP9]], label [[BB3]], label [[BB0_NONCHR:%.*]], !prof !16
558560
; CHECK: bb0.nonchr:
559-
; CHECK-NEXT: [[TMP9:%.*]] = and i32 [[TMP0]], 1
560-
; CHECK-NEXT: [[TMP10:%.*]] = icmp eq i32 [[TMP9]], 0
561-
; CHECK-NEXT: [[TMP11:%.*]] = add i32 [[SUM0]], 42
562-
; CHECK-NEXT: [[SUM1_NONCHR:%.*]] = select i1 [[TMP10]], i32 [[SUM0]], i32 [[TMP11]], !prof !16
563-
; CHECK-NEXT: [[TMP12:%.*]] = and i32 [[TMP0]], 2
564-
; CHECK-NEXT: [[TMP13:%.*]] = icmp eq i32 [[TMP12]], 0
565-
; CHECK-NEXT: [[TMP14:%.*]] = add i32 [[SUM1_NONCHR]], 43
566-
; CHECK-NEXT: [[SUM2_NONCHR:%.*]] = select i1 [[TMP13]], i32 [[SUM1_NONCHR]], i32 [[TMP14]], !prof !16
567-
; CHECK-NEXT: [[TMP15:%.*]] = and i32 [[SUM0]], 4
568-
; CHECK-NEXT: [[TMP16:%.*]] = icmp eq i32 [[TMP15]], 0
569-
; CHECK-NEXT: [[TMP17:%.*]] = and i32 [[TMP0]], 8
570-
; CHECK-NEXT: [[TMP18:%.*]] = icmp eq i32 [[TMP17]], 0
571-
; CHECK-NEXT: [[SUM4_NONCHR_V:%.*]] = select i1 [[TMP18]], i32 44, i32 88
561+
; CHECK-NEXT: [[TMP10:%.*]] = and i32 [[TMP0]], 1
562+
; CHECK-NEXT: [[TMP11:%.*]] = icmp eq i32 [[TMP10]], 0
563+
; CHECK-NEXT: [[TMP12:%.*]] = add i32 [[SUM0]], 42
564+
; CHECK-NEXT: [[SUM1_NONCHR:%.*]] = select i1 [[TMP11]], i32 [[SUM0]], i32 [[TMP12]], !prof !16
565+
; CHECK-NEXT: [[TMP13:%.*]] = and i32 [[TMP0]], 2
566+
; CHECK-NEXT: [[TMP14:%.*]] = icmp eq i32 [[TMP13]], 0
567+
; CHECK-NEXT: [[TMP15:%.*]] = add i32 [[SUM1_NONCHR]], 43
568+
; CHECK-NEXT: [[SUM2_NONCHR:%.*]] = select i1 [[TMP14]], i32 [[SUM1_NONCHR]], i32 [[TMP15]], !prof !16
569+
; CHECK-NEXT: [[TMP16:%.*]] = and i32 [[SUM0]], 4
570+
; CHECK-NEXT: [[TMP17:%.*]] = icmp eq i32 [[TMP16]], 0
571+
; CHECK-NEXT: [[TMP18:%.*]] = and i32 [[TMP0]], 8
572+
; CHECK-NEXT: [[TMP19:%.*]] = icmp eq i32 [[TMP18]], 0
573+
; CHECK-NEXT: [[SUM4_NONCHR_V:%.*]] = select i1 [[TMP19]], i32 44, i32 88
572574
; CHECK-NEXT: [[SUM4_NONCHR:%.*]] = add i32 [[SUM2_NONCHR]], [[SUM4_NONCHR_V]]
573-
; CHECK-NEXT: [[SUM5_NONCHR:%.*]] = select i1 [[TMP16]], i32 [[SUM2_NONCHR]], i32 [[SUM4_NONCHR]], !prof !16
575+
; CHECK-NEXT: [[SUM5_NONCHR:%.*]] = select i1 [[TMP17]], i32 [[SUM2_NONCHR]], i32 [[SUM4_NONCHR]], !prof !16
574576
; CHECK-NEXT: br label [[BB3]]
575577
; CHECK: bb3:
576-
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[TMP6]], [[BB1]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
578+
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[TMP7]], [[BB0]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
577579
; CHECK-NEXT: ret i32 [[SUM6]]
578580
;
579581
entry:
@@ -647,9 +649,10 @@ define i32 @test_chr_6(i32* %i, i32* %j, i32 %sum0) !prof !14 {
647649
; CHECK-NEXT: [[TMP0:%.*]] = and i32 [[I0]], 10
648650
; CHECK-NEXT: [[TMP1:%.*]] = icmp eq i32 [[TMP0]], 10
649651
; CHECK-NEXT: [[TMP2:%.*]] = and i1 [[TMP1]], [[V10]]
650-
; CHECK-NEXT: br i1 [[TMP2]], label [[BB1:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
651-
; CHECK: bb1:
652-
; CHECK-NEXT: [[V13:%.*]] = add i32 [[SUM0:%.*]], 131
652+
; CHECK-NEXT: br i1 [[TMP2]], label [[BB0:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
653+
; CHECK: bb0:
654+
; CHECK-NEXT: [[V8:%.*]] = add i32 [[SUM0:%.*]], 43
655+
; CHECK-NEXT: [[V13:%.*]] = add i32 [[SUM0]], 131
653656
; CHECK-NEXT: br label [[BB3:%.*]]
654657
; CHECK: entry.split.nonchr:
655658
; CHECK-NEXT: [[V1:%.*]] = and i32 [[I0]], 255
@@ -669,7 +672,7 @@ define i32 @test_chr_6(i32* %i, i32* %j, i32 %sum0) !prof !14 {
669672
; CHECK-NEXT: [[SUM5_NONCHR:%.*]] = select i1 [[V10_NONCHR]], i32 [[SUM2_NONCHR]], i32 [[SUM4_NONCHR]], !prof !16
670673
; CHECK-NEXT: br label [[BB3]]
671674
; CHECK: bb3:
672-
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[V13]], [[BB1]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
675+
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[V13]], [[BB0]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
673676
; CHECK-NEXT: ret i32 [[SUM6]]
674677
;
675678
entry:
@@ -1734,27 +1737,28 @@ define i32 @test_chr_19(i32* %i, i32 %sum0) !prof !14 {
17341737
; CHECK-NEXT: [[TMP0:%.*]] = load i32, i32* [[I:%.*]], align 4
17351738
; CHECK-NEXT: [[TMP1:%.*]] = and i32 [[TMP0]], 9
17361739
; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i32 [[TMP1]], 9
1737-
; CHECK-NEXT: br i1 [[TMP2]], label [[BB1:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
1738-
; CHECK: bb1:
1739-
; CHECK-NEXT: [[TMP3:%.*]] = add i32 [[SUM0:%.*]], 173
1740+
; CHECK-NEXT: br i1 [[TMP2]], label [[BB0:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
1741+
; CHECK: bb0:
1742+
; CHECK-NEXT: [[TMP3:%.*]] = add i32 [[SUM0:%.*]], 85
1743+
; CHECK-NEXT: [[TMP4:%.*]] = add i32 [[SUM0]], 173
17401744
; CHECK-NEXT: br label [[BB3:%.*]]
17411745
; CHECK: entry.split.nonchr:
1742-
; CHECK-NEXT: [[TMP4:%.*]] = and i32 [[TMP0]], 255
1743-
; CHECK-NEXT: [[TMP5:%.*]] = icmp eq i32 [[TMP4]], 0
1744-
; CHECK-NEXT: br i1 [[TMP5]], label [[BB3]], label [[BB0_NONCHR:%.*]], !prof !16
1746+
; CHECK-NEXT: [[TMP5:%.*]] = and i32 [[TMP0]], 255
1747+
; CHECK-NEXT: [[TMP6:%.*]] = icmp eq i32 [[TMP5]], 0
1748+
; CHECK-NEXT: br i1 [[TMP6]], label [[BB3]], label [[BB0_NONCHR:%.*]], !prof !16
17451749
; CHECK: bb0.nonchr:
1746-
; CHECK-NEXT: [[TMP6:%.*]] = and i32 [[TMP0]], 1
1747-
; CHECK-NEXT: [[TMP7:%.*]] = icmp eq i32 [[TMP6]], 0
1748-
; CHECK-NEXT: [[TMP8:%.*]] = add i32 [[SUM0]], 85
1749-
; CHECK-NEXT: [[SUM2_NONCHR:%.*]] = select i1 [[TMP7]], i32 [[SUM0]], i32 [[TMP8]], !prof !16
1750-
; CHECK-NEXT: [[TMP9:%.*]] = and i32 [[TMP0]], 8
1751-
; CHECK-NEXT: [[TMP10:%.*]] = icmp eq i32 [[TMP9]], 0
1752-
; CHECK-NEXT: [[SUM4_NONCHR_V:%.*]] = select i1 [[TMP10]], i32 44, i32 88
1750+
; CHECK-NEXT: [[TMP7:%.*]] = and i32 [[TMP0]], 1
1751+
; CHECK-NEXT: [[TMP8:%.*]] = icmp eq i32 [[TMP7]], 0
1752+
; CHECK-NEXT: [[TMP9:%.*]] = add i32 [[SUM0]], 85
1753+
; CHECK-NEXT: [[SUM2_NONCHR:%.*]] = select i1 [[TMP8]], i32 [[SUM0]], i32 [[TMP9]], !prof !16
1754+
; CHECK-NEXT: [[TMP10:%.*]] = and i32 [[TMP0]], 8
1755+
; CHECK-NEXT: [[TMP11:%.*]] = icmp eq i32 [[TMP10]], 0
1756+
; CHECK-NEXT: [[SUM4_NONCHR_V:%.*]] = select i1 [[TMP11]], i32 44, i32 88
17531757
; CHECK-NEXT: [[SUM4_NONCHR:%.*]] = add i32 [[SUM2_NONCHR]], [[SUM4_NONCHR_V]]
1754-
; CHECK-NEXT: [[SUM5_NONCHR:%.*]] = select i1 [[TMP7]], i32 [[SUM2_NONCHR]], i32 [[SUM4_NONCHR]], !prof !16
1758+
; CHECK-NEXT: [[SUM5_NONCHR:%.*]] = select i1 [[TMP8]], i32 [[SUM2_NONCHR]], i32 [[SUM4_NONCHR]], !prof !16
17551759
; CHECK-NEXT: br label [[BB3]]
17561760
; CHECK: bb3:
1757-
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[TMP3]], [[BB1]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
1761+
; CHECK-NEXT: [[SUM6:%.*]] = phi i32 [ [[TMP4]], [[BB0]] ], [ [[SUM0]], [[ENTRY_SPLIT_NONCHR]] ], [ [[SUM5_NONCHR]], [[BB0_NONCHR]] ]
17581762
; CHECK-NEXT: ret i32 [[SUM6]]
17591763
;
17601764
entry:

0 commit comments

Comments
 (0)