[mlir] Drop const from SymbolTableCollection::lookupSymbolIn

Jeff Niu · Jeff Niu · commit f530e6e34ee1 · 2022-11-05T16:28:30.000-07:00
This function didn't work because it was marked const but both functions it could dispatch to are not. Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D137380
diff --git a/mlir/include/mlir/IR/SymbolTable.h b/mlir/include/mlir/IR/SymbolTable.h
@@ -249,7 +249,7 @@ class SymbolTableCollection {
   Operation *lookupSymbolIn(Operation *symbolTableOp, StringAttr symbol);
   Operation *lookupSymbolIn(Operation *symbolTableOp, SymbolRefAttr name);
   template <typename T, typename NameT>
-  T lookupSymbolIn(Operation *symbolTableOp, NameT &&name) const {
+  T lookupSymbolIn(Operation *symbolTableOp, NameT &&name) {
     return dyn_cast_or_null<T>(
         lookupSymbolIn(symbolTableOp, std::forward<NameT>(name)));
   }

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ class SymbolTableCollection {`
`249`	`249`	`Operation lookupSymbolIn(Operation symbolTableOp, StringAttr symbol);`
`250`	`250`	`Operation lookupSymbolIn(Operation symbolTableOp, SymbolRefAttr name);`
`251`	`251`	`template <typename T, typename NameT>`
`252`		`- T lookupSymbolIn(Operation *symbolTableOp, NameT &&name) const {`
	`252`	`+ T lookupSymbolIn(Operation *symbolTableOp, NameT &&name) {`
`253`	`253`	`return dyn_cast_or_null<T>(`
`254`	`254`	`lookupSymbolIn(symbolTableOp, std::forward<NameT>(name)));`
`255`	`255`	`}`