Skip to content

Commit f97a579

Browse files
committed
[runtimes] Add TODO about CXX_STANDARD_REQUIRED being off after review comment
1 parent 337f0ed commit f97a579

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

libcxx/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ function(cxx_add_basic_build_flags target)
507507
# Use C++23 for all targets.
508508
set_target_properties(${target} PROPERTIES
509509
CXX_STANDARD 23
510-
CXX_STANDARD_REQUIRED OFF
510+
CXX_STANDARD_REQUIRED OFF # TODO: Make this REQUIRED once we don't need to accommodate the LLVM documentation builders using an ancient CMake
511511
CXX_EXTENSIONS NO)
512512

513513
# When building the dylib, don't warn for unavailable aligned allocation

libcxxabi/src/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ set_target_properties(cxxabi_shared_objects
172172
PROPERTIES
173173
CXX_EXTENSIONS OFF
174174
CXX_STANDARD 23
175-
CXX_STANDARD_REQUIRED OFF
175+
CXX_STANDARD_REQUIRED OFF # TODO: Make this REQUIRED once we don't need to accommodate the LLVM documentation builders using an ancient CMake
176176
COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS}"
177177
DEFINE_SYMBOL ""
178178
)
@@ -252,7 +252,7 @@ set_target_properties(cxxabi_static_objects
252252
PROPERTIES
253253
CXX_EXTENSIONS OFF
254254
CXX_STANDARD 23
255-
CXX_STANDARD_REQUIRED OFF
255+
CXX_STANDARD_REQUIRED OFF # TODO: Make this REQUIRED once we don't need to accommodate the LLVM documentation builders using an ancient CMake
256256
COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS}"
257257
)
258258

0 commit comments

Comments
 (0)