Skip to content

Commit faed85b

Browse files
authored
[lldb][test][NFC] Document DYLIB_NAME Makefile variable (llvm#112735)
Got caught out by this because simply specifying `DYLIB_CXX_SOURCES` (without specifying `DYLIB_NAME`) resulted in linker errors because the dylib was never built (and linked). We should probably make that a Makefile error (though I haven't audited when exactly not specifying `DYLIB_NAME` is valid; looked like that can happen when we specify `FRAMEWORK`).
1 parent 5e81437 commit faed85b

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

lldb/packages/Python/lldbsuite/test/make/Makefile.rules

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,13 @@
1313
# the building of the a.out executable program. For example,
1414
# DYLIB_ONLY := YES
1515
#
16+
# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
17+
# controls the (platform-dependent) name of the produced dylib. E.g.,
18+
# on Darwin, if "DYLIB_NAME := foo", the generated dylib will be called
19+
# "libfoo.dylib".
20+
#
21+
# DYLIB_NAME := foo
22+
#
1623
# Specifying FRAMEWORK and its variants has the effect of building a NeXT-style
1724
# framework.
1825
# FRAMEWORK := "Foo"

0 commit comments

Comments
 (0)