[lldb] Stop unconditionally emitting "could not resolve type"

kastiglione · kastiglione · commit fbdc88ef3ae9 · 2020-09-29T23:18:29.000-07:00
diff --git a/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp b/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp
@@ -8080,12 +8080,13 @@ void SwiftASTContext::DumpTypeDescription(opaque_compiler_type_t type,
       }
     } break;
     }
+  }
 
-    if (buf.size() > 0) {
-      s->Write(buf.data(), buf.size());
-    }
+  if (buf.size() > 0) {
+    s->Write(buf.data(), buf.size());
+  } else {
+    s->Printf("<could not resolve type>");
   }
-  s->Printf("<could not resolve type>");
 }
 
 TypeSP SwiftASTContext::GetCachedType(ConstString mangled) {

Original file line number	Diff line number	Diff line change
`@@ -8080,12 +8080,13 @@ void SwiftASTContext::DumpTypeDescription(opaque_compiler_type_t type,`
`8080`	`8080`	`}`
`8081`	`8081`	`} break;`
`8082`	`8082`	`}`
	`8083`	`+ }`
`8083`	`8084`
`8084`		`- if (buf.size() > 0) {`
`8085`		`- s->Write(buf.data(), buf.size());`
`8086`		`- }`
	`8085`	`+ if (buf.size() > 0) {`
	`8086`	`+ s->Write(buf.data(), buf.size());`
	`8087`	`+ } else {`
	`8088`	`+ s->Printf("<could not resolve type>");`
`8087`	`8089`	`}`
`8088`		`- s->Printf("<could not resolve type>");`
`8089`	`8090`	`}`
`8090`	`8091`
`8091`	`8092`	`TypeSP SwiftASTContext::GetCachedType(ConstString mangled) {`