[lldb] Exclude redundant task flags from summary #10374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't show `future` or `childTask` in a Task's summary. First, `future` is not an official term in Swift Concurrency. There's undetermined value in showing this. From my reading of the concurrency runtime, in non-embedded Swift all tasks have the flag `isFuture`. For embedded Swift all tasks do not have the flag set. Second, child tasks are already indicated with either `groupChildTask`, or `asyncLetTask`. Both values are available on demand, ex `p task.isFuture` or `p task.isChildTask`. This change is to reduce the quantity of data in the summary, because a subsequent change will include the Tasks name in its summary.
|
@swift-ci test |
|
looks like an appropriate choice to me! |
felipepiovezan
approved these changes
Mar 30, 2025
kastiglione
deleted the
dl/lldb-Exclude-redundant-task-flags-from-summary
branch
kastiglione
added a commit
that referenced
this pull request
Apr 4, 2025
Don't show `future` or `childTask` flags in a Task's summary. First, `future` is not an official term in Swift Concurrency. There's undetermined value in showing this. From my reading of the concurrency runtime, in non-embedded Swift all tasks have the flag `isFuture`. For embedded Swift it's _unset_ for all tasks. Second, child tasks are already indicated with either `groupChildTask`, or `asyncLetTask`. Both values are still available on demand, ex `p task.isFuture` or `p task.isChildTask`. This change is to reduce the quantity of data in the summary, because a subsequent change will add the Task's name in its summary. (cherry-picked from commit bc6899f)
kastiglione
added a commit
that referenced
this pull request
Apr 4, 2025
Don't show `future` or `childTask` flags in a Task's summary. First, `future` is not an official term in Swift Concurrency. There's undetermined value in showing this. From my reading of the concurrency runtime, in non-embedded Swift all tasks have the flag `isFuture`. For embedded Swift it's _unset_ for all tasks. Second, child tasks are already indicated with either `groupChildTask`, or `asyncLetTask`. Both values are still available on demand, ex `p task.isFuture` or `p task.isChildTask`. This change is to reduce the quantity of data in the summary, because a subsequent change will add the Task's name in its summary. (cherry-picked from commit bc6899f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show
futureorchildTaskflags in a Task's summary.First,
futureis not an official term in Swift Concurrency. There's undetermined valuein showing this. From my reading of the concurrency runtime, in non-embedded Swift all
tasks have the flag
isFuture. For embedded Swift it's unset for all tasks.Second, child tasks are already indicated with either
groupChildTask, orasyncLetTask.Both values are still available on demand, ex
p task.isFutureorp task.isChildTask.This change is to reduce the quantity of data in the summary, because a subsequent
change will add the Task's name in its summary.