forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 344
[BoundsSafety] Partially Upstream support for BS_CHK_LibCAttributes
for Apple platforms
#10544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
devincoughlin
merged 1 commit into
swiftlang:swift/release/6.2
from
delcypher:dliew/rdar-149243724-cherry-pick
Apr 25, 2025
Merged
[BoundsSafety] Partially Upstream support for BS_CHK_LibCAttributes
for Apple platforms
#10544
devincoughlin
merged 1 commit into
swiftlang:swift/release/6.2
from
delcypher:dliew/rdar-149243724-cherry-pick
Apr 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Apple platforms This adds the compiler side implementation of the new `BS_CHK_LibCAttributes` bounds check for the Darwin toolchain. When `-fbounds-safety-bringup-missing-checks=libc_attributes` is enabled and when compiling for Apple platforms with a userspace Libc the `__LIBC_STAGED_BOUNDS_SAFETY_ATTRIBUTES` macro is enabled. This macro communicates to Libc that it should switch on the new `-fbounds-safety` annotations. rdar://149243724 (cherry picked from commit 6829d4a)
@swift-ci test llvm |
@swift-ci test |
This is a prerequisite for implementing rdar://148623233. |
macOS LLVM testing failed with:
|
rapidsna
approved these changes
Apr 24, 2025
@swift-ci test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the compiler side implementation of the new
BS_CHK_LibCAttributes
bounds check for the Darwin toolchain. When-fbounds-safety-bringup-missing-checks=libc_attributes
is enabled and when compiling for Apple platforms with a userspace Libc the__LIBC_STAGED_BOUNDS_SAFETY_ATTRIBUTES
macro is enabled. This macro communicates to Libc that it should switch on the new-fbounds-safety
annotations.rdar://149243724
(cherry picked from commit 6829d4a)