Skip to content

[Cherry-pick into next] [lldb] Factor our binding generic variadic types (NFC) #10677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

[Cherry-pick into next] [lldb] Factor our binding generic variadic types (NFC) #10677

merged 3 commits into from
May 14, 2025

Conversation

adrian-prantl
Copy link 

commit d7572b37c29c9adf9ff9f1c5aafbf13575e6d3ff
Author: Adrian Prantl <[email protected]>
Date:   Tue May 13 09:50:35 2025 -0700

    [lldb] Factor our binding generic variadic types (NFC)

commit 50f15f2a48716ab000b0ff906b163e5813da6a3d
Author: Adrian Prantl <[email protected]>
Date:   Tue May 13 16:12:21 2025 -0700

    [lldb] Make variadic generic types work with TypeSystemSwiftTypeRef
    
    The missing ingredient were the reflection support for pack types, and
    binding pack type in BindGenericParameters().
    
    rdar://145257088

commit e48e8aad0b3b1808260e520b1f92f0e608f15ce9
Author: Adrian Prantl <[email protected]>
Date:   Tue May 13 16:58:07 2025 -0700

    [lldb] Convert BindGenericTypeParameters to llvm::Expected

@adrian-prantl
[lldb] Factor our binding generic variadic types (NFC)
863d6c9 
(cherry picked from commit d7572b3)
@adrian-prantl
[lldb] Make variadic generic types work with TypeSystemSwiftTypeRef
9022196 
The missing ingredient were the reflection support for pack types, and
binding pack type in BindGenericParameters().

rdar://145257088
(cherry picked from commit 50f15f2)
@adrian-prantl
[lldb] Convert BindGenericTypeParameters to llvm::Expected
8ce32ab 
(cherry picked from commit e48e8aa)
@adrian-prantl adrian-prantl merged commit 73ed88d into swiftlang:next May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere JDevlieghere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrian-prantl