[cherry-pick][lldb] Cherry pick arrm64e swift async unwinding fixes #10689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With arm64e, many more branches are generated, which cause the debugger to stop more often while stepping. Among those stops are code regions where the debugger gets confused about what is stored in the async register stack slot. This commit revives a heuristic that was previously used by default for all architectures and that works in all PC addresses, but that sacrifices unwinding o recursive functions. It is only used if the target is arm64e. (cherry picked from commit c964d56)
(cherry picked from commit 2e847d0)
…geRuntime This is required so that the breakpoint may be resolved correctly in case the address has been signed. (cherry picked from commit 2c318f1)
The code comparing async context addresses need to strip any pointer authentication bits, otherwise the integer comparison will always fail. (cherry picked from commit 6e361c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits from : #10671