Skip to content

[lldb][swift] Handle asyncLet_get_throwing trampoline #10783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

felipepiovezan
Copy link

This can also cause a task switch and should be handled like swift_task_switch and asyncLet_get.

This can also cause a task switch and should be handled like
`swift_task_switch` and `asyncLet_get`.
@felipepiovezan felipepiovezan requested a review from a team as a code owner June 3, 2025 22:05
@felipepiovezan
Copy link
Author

@swift-ci test

@@ -14,13 +14,13 @@ def check_is_in_line(self, thread, linenum):

@swiftTest
@skipIf(oslist=["windows", "linux"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment why it's skipped on Linux?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All async tests are skipped on Linux right now.
I believe we should be close to being able to support them there -- we no longer rely on platform choices that are not done on Linux (e.g. tagging FP) -- but someone needs to do the work of trying it out

@adrian-prantl adrian-prantl merged commit cf4a54e into swiftlang:swift/release/6.2 Jun 4, 2025
3 checks passed
felipepiovezan added a commit that referenced this pull request Jun 11, 2025
This can also cause a task switch and should be handled like
`swift_task_switch` and `asyncLet_get`.

(cherry picked from commit cf4a54e)
felipepiovezan added a commit that referenced this pull request Jun 11, 2025
…clet-fix

🍒[lldb][swift] Handle `asyncLet_get_throwing` trampoline (#10783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants