[cmake] Unconditionally set the force flag when codesigning #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Darwin linker now defaults to ad hoc signing binaries when targeting Apple Silicon. This creates a problem when configuring targets that must be built with entitlements: we either need to add -Wl,-no_adhoc_codesign when building the target, or sign with the force flag set to allow replacing a pre-existing signature. Unconditionally force-signing is the more convenient solution. This doesn't require a ld64 version check, and it's a much less invasive cmake change. Patch by Fred Riss! rdar://70237254 Differential Revision: https://reviews.llvm.org/D89343 (cherry picked from commit 24c1660)
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.