Skip to content

[cmake] Add python bindings to the Apple-lldb-Linux distribution #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcrasi
Copy link

@marcrasi marcrasi commented Dec 3, 2020

I would like swift-jupyter to work with the stock Swift builds on swift.org.

Everything is compatible, except for one thing: swift-jupyter uses the LLDB Python bindings, which are not built into the Swift builds by default.

This change adds the LLDB Python bindings to the build.

@marcrasi marcrasi requested a review from JDevlieghere December 3, 2020 23:59
Copy link

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcrasi
Copy link
Author

marcrasi commented Dec 4, 2020

@swift-ci please test

1 similar comment
@marcrasi
Copy link
Author

marcrasi commented Dec 4, 2020

@swift-ci please test

@marcrasi
Copy link
Author

marcrasi commented Dec 5, 2020

@swift-ci please test macos

@marcrasi marcrasi merged commit 8300508 into swiftlang:swift/main Dec 7, 2020
@marcrasi marcrasi deleted the add-python-bindings-to-linux branch December 7, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants