[lldb] Disable deserialization safety for lldb #6060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Deserialization safety prevents reading internal implementation details from swiftmodules files. Let's disable it for LLDB as these details are useful for debugging and LLDB enables more deserialization recovery. The recovery should help handle the same issues avoided by the safety. We can also expand the recovery more liberally if it crashes under paths avoided under safety.
xymus
force-pushed
the
lldb-disable-safety
branch
from
3e93ad0 to
d4e60e2
Compare
|
@swift-ci please test |
|
@xymus please make sure to also cherry-pick this to |
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserialization safety prevents reading internal implementation details from swiftmodules files. Let's disable it for LLDB as these details are useful for debugging and LLDB enables more deserialization recovery. The recovery should help handle the same issues avoided by the safety. We can also expand the recovery more liberally if it crashes under paths avoided under safety.