Skip to content

🍒/6672a4f5b64f6b5a17cba63b421fcf313003b5b8 #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2020
Merged

🍒/6672a4f5b64f6b5a17cba63b421fcf313003b5b8 #646

merged 2 commits into from
Jan 24, 2020

Conversation

JDevlieghere
Copy link 

commit a8930d256d982f456f6d337efabfabfdfc2d705f
Author: Jonas Devlieghere <[email protected]>
Date:   Thu Jan 23 14:17:48 2020 -0800

    [lldb/Test] Disable command-breakpoint-col.test on Windows

    I guess PDB doesn't have column information?

    (cherry picked from commit d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3)

commit 2efadd4e3096aec614cef3aa7c43e480c1cc3023
Author: Jonas Devlieghere <[email protected]>
Date:   Thu Jan 23 11:25:16 2020 -0800

    [lldb/Commands] Fix, rename and document column number arg to breakpoint set.

    We were incorrectly parsing the -C argument to breakpoint set as the
    column breakpoint, even though according to the help this should be the
    breakpoint command. This fixes that by renaming the option to -u, adding
    it to help, and adding a test case.

    Differential revision: https://reviews.llvm.org/D73284

    (cherry picked from commit 6672a4f5b64f6b5a17cba63b421fcf313003b5b8)

@JDevlieghere
[lldb/Commands] Fix, rename and document column number arg to breakpo…
2efadd4 
…int set.

We were incorrectly parsing the -C argument to breakpoint set as the
column breakpoint, even though according to the help this should be the
breakpoint command. This fixes that by renaming the option to -u, adding
it to help, and adding a test case.

Differential revision: https://reviews.llvm.org/D73284

(cherry picked from commit 6672a4f)
@JDevlieghere
[lldb/Test] Disable command-breakpoint-col.test on Windows
a8930d2 
I guess PDB doesn't have column information?

(cherry picked from commit d8acf88)
@JDevlieghere JDevlieghere requested a review from fredriss January 23, 2020 22:32
@JDevlieghere
Copy link
Author

@swift-ci please test macos

@JDevlieghere JDevlieghere merged commit 93bc7d7 into swiftlang:apple/stable/20190619 Jan 24, 2020
@JDevlieghere JDevlieghere deleted the 🍒/6672a4f5b64f6b5a17cba63b421fcf313003b5b8 branch January 24, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredriss fredriss fredriss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JDevlieghere @fredriss