Rsundahl/docweakswift5.9 #6699
Merged
Rsundahl/docweakswift5.9 #6699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain in the release notes that the Darwin dynamic linker (dyld) requires that at least one weak symbol be present in any mach-o file that defines an intended override of a sanitizer dylib weak reference. rdar://103453678 Reviewed By: thetruestblue Differential Revision: https://reviews.llvm.org/D146745 (cherry picked from commit f1c5c84)
…in. (NFC) Presenting more than one way to satisfy the single-weak-ref requirement leads to confusing messaging for the end user. Use the introduction of a single unused weak variable as the preferred solution. This differential modifies D146745. rdar://103453678 Reviewed By: yln, thetruestblue Differential Revision: https://reviews.llvm.org/D147526 (cherry picked from commit 5f17ba1)
This addresses issues found by: https://lab.llvm.org/buildbot/#/builders/30/builds/33698 (cherry picked from commit ceacb32)
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.