Skip to content

Avoid a potential use-after-free by storing a std::string (NFC) #7111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

Avoid a potential use-after-free by storing a std::string (NFC) #7111

merged 1 commit into from
Jul 28, 2023
+15 −17

Conversation

adrian-prantl
Copy link

rdar://111956360

@adrian-prantl
Copy link
Author

@swift-ci test

JDevlieghere
JDevlieghere approved these changes Jul 28, 2023
View reviewed changes
Copy link

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward. Most of the changed lines are due to reordering. LGTM.

@adrian-prantl adrian-prantl merged commit 53b62ee into swiftlang:swift/release/5.9 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDevlieghere JDevlieghere JDevlieghere approved these changes

@augusto2112 augusto2112 augusto2112 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-prantl @JDevlieghere @augusto2112