Skip to content

Deal with DIComposite types which aren't enums in isUnsignedDIType #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

augusto2112
Copy link

No description provided.

@augusto2112
Copy link
Author

@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but please upstream this soon.

@augusto2112
Copy link
Author

@swift-ci test Windows

@augusto2112 augusto2112 merged commit 7c093d5 into swiftlang:stable/20230725 Mar 18, 2024
@adrian-prantl
Copy link

@augusto2112 Remember, you will need to re-cherry pick this to swift/release/6.0

@drodriguez
Copy link

This change makes LLVM :: DebugInfo/COFF/global-constants.ll fail.

llc outputs the following after these changes:

.Ltmp18:
	.short	4359                            # Record kind: S_CONSTANT
	.long	4101                            # Type
	.byte	0x0a, 0x80, 0x40, 0x61          # Value
	.byte	0x07, 0x80, 0xff, 0xff
	.byte	0xff, 0xff
	.asciz	"ENUM_B"                        # Name
	.p2align	2, 0x0

But the test is expecting a different bytes:

; ASM:        .short  4359                    # Record kind: S_CONSTANT
; ASM-NEXT:   .long 4101                    # Type
; ASM-NEXT:   .byte 0x03, 0x80, 0x40, 0x61  # Value
; ASM-NEXT:   .byte 0x07, 0x80
; ASM-NEXT:   .asciz  "ENUM_B"                # Name
; ASM-NEXT:   .p2align  2
; ASM-NOT:    .asciz "S::SEnum"             # Name

There's also more problems if you remove the first test and let the second test run.

@augusto2112
Copy link
Author

@drodriguez thanks, I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants