Skip to content

Rewrite MCCAS Debug Info creation as iterative #8585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

rastogishubham
Copy link

The MCCAS code responsible for creating the debug info section representation is written recursively, which could lead to a stack overflow, this patches rewrites it to be recursive.

@rastogishubham rastogishubham force-pushed the RewriteMCCASDebugInfo branch 2 times, most recently from d66da3e to 7cdf06c Compare April 16, 2024 23:39
@rastogishubham
Copy link
Author

@swift-ci please test llvm

Copy link

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some high level suggestions, but I really like how simple this already is :D

The MCCAS code responsible for creating the debug info section
representation is written recursively, which could lead to a stack
overflow, this patches rewrites it to be recursive.
Copy link

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rastogishubham rastogishubham merged commit 9384d0c into swiftlang:next Apr 23, 2024
@rastogishubham rastogishubham deleted the RewriteMCCASDebugInfo branch April 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants