[lldb] Guard SetDescriptorFinderAndClearOnExit against recursion #8674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
approved these changes
May 2, 2024
lldb/source/Plugins/LanguageRuntime/Swift/ReflectionContext.cpp
Outdated
Show resolved
Hide resolved
If a function in ReflectionContext.cpp sets the descriptor finder and calls another one that does the same, when the second function finishes the descriptor finder will be cleared. Fix this by keeping a stack of descriptor finders. rdar://122586257
augusto2112
force-pushed
the
rec-desc-finder
branch
from
503d21b to
28101fa
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a function in ReflectionContext.cpp sets the descriptor finder and calls another one that does the same, when the second function finishes the descriptor finder will be cleared. Fix this by keeping a stack of descriptor finders.
rdar://122586257