Fix the dsymutil heuristic for excluding system interfaces. (#93745) #8820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was meant to find the Developer/ dir, but it found a Developer directory nested deep inside the top-level Developer dir. The new implementation rejects everything in Xcode.app/Developer in broad strokes. rdar://128571037 (cherry picked from commit f8cc183) Conflicts: llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp llvm/lib/DWARFLinker/Parallel/DWARFLinkerCompileUnit.cpp
|
@swift-ci test |
|
@swift-ci test llvm |
JDevlieghere
approved these changes
May 30, 2024
and reject them when copying Swift interface files, since they can live outside of DEVELOPER_DIR. (cherry picked from commit 22ada55)
|
@swift-ci test |
|
@swift-ci test llvm |
|
@swift-ci test windows |
|
@swift-ci test llvm-project |
|
@swift-ci test macos |
|
@swift-ci test linux |
|
@swift-ci test windows |
|
LLVM test failures are unrelated |
adrian-prantl
merged commit de66661
into
swiftlang:swift/release/6.0
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was meant to find the Developer/ dir, but it found a Developer directory nested deep inside the top-level Developer dir.
The new implementation rejects everything in Xcode.app/Developer in broad strokes.
rdar://128571037
(cherry picked from commit f8cc183)
Conflicts:
llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp
llvm/lib/DWARFLinker/Parallel/DWARFLinkerCompileUnit.cpp