[🍒][-Wunsafe-buffer-usage] Warning unsafe libc calls #9287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
I somehow can't find @jkorous-apple in the reviewer list. |
Doesn't work for me either hmm. |
|
Weird, I am here 🤷 |
yeah, that works the best. |
ziqingluo-90
force-pushed
the
ziqing/stable/20240723
branch
from
12700fe to
9ddbe6a
Compare
|
Rebased, and @swift-ci test |
ziqingluo-90
force-pushed
the
ziqing/stable/20240723
branch
from
9ddbe6a to
99d1407
Compare
|
Rebased, and @swift-ci test |
[-Wunsafe-buffer-usage] Add warn on unsafe calls to libc functions Warning about calls to libc functions involving buffer access. Warned functions are hardcoded by names. (rdar://117182250) (cherry picked from commit 0fffdeb)
…n libc warnings (llvm#108308) For `snprintf(a, sizeof a, ...)`, the first two arguments form a safe pattern if `a` is a constant array. In such a case, this commit will suppress the warning. (rdar://117182250) (cherry picked from commit ebf25d9)
… Warning Libc functions (llvm#101583)" StringLiteral::getString() is not applicable to strings of wide characters. Added handling for that. (rdar://117182250) (cherry picked from commit 48498ec)
…les (llvm#109496) - Fix a bug in UnsafeBufferUsage.cpp related to casting to PointerType - Suppress -Wunsafe-buffer-usage-in-libc-call for C files (rdar://117182250) (cherry picked from commit 090dc77)
ziqingluo-90
force-pushed
the
ziqing/stable/20240723
branch
from
99d1407 to
7d22451
Compare
|
Rebased, and @swift-ci test |
|
LGTM |
haoNoQ
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from
swiftlang/llvm-project/next