Skip to content

Commit 02576d6

Browse files
committed
Change QueuedTask.cancelledToBeRescheduled to be a normal Bool instead of an atomic
It’s only modified from method isolated to `QueuedTask`, so there’s no need for it to be an `AtomicBool`.
1 parent 505f4cf commit 02576d6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Sources/SKCore/TaskScheduler.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ public actor QueuedTask<TaskDescription: TaskDescriptionProtocol> {
144144
/// Whether `cancelToBeRescheduled` has been called on this `QueuedTask`.
145145
///
146146
/// Gets reset every time `executionTask` finishes.
147-
nonisolated(unsafe) private var cancelledToBeRescheduled: AtomicBool = .init(initialValue: false)
147+
private var cancelledToBeRescheduled: Bool = false
148148

149149
/// Whether `resultTask` has been cancelled.
150150
private nonisolated(unsafe) var resultTaskCancelled: AtomicBool = .init(initialValue: false)
@@ -246,9 +246,9 @@ public actor QueuedTask<TaskDescription: TaskDescriptionProtocol> {
246246
private func finalizeExecution() async -> ExecutionTaskFinishStatus {
247247
self.executionTask = nil
248248
_isExecuting.value = false
249-
if Task.isCancelled && self.cancelledToBeRescheduled.value {
249+
if Task.isCancelled && self.cancelledToBeRescheduled {
250250
await executionStateChangedCallback?(self, .cancelledToBeRescheduled)
251-
self.cancelledToBeRescheduled.value = false
251+
self.cancelledToBeRescheduled = false
252252
return ExecutionTaskFinishStatus.cancelledToBeRescheduled
253253
} else {
254254
await executionStateChangedCallback?(self, .finished)
@@ -263,7 +263,7 @@ public actor QueuedTask<TaskDescription: TaskDescriptionProtocol> {
263263
guard let executionTask else {
264264
return
265265
}
266-
self.cancelledToBeRescheduled.value = true
266+
self.cancelledToBeRescheduled = true
267267
executionTask.cancel()
268268
self.executionTask = nil
269269
}

0 commit comments

Comments
 (0)