Merge pull request #1394 from ahoppen/thread-safe-box-sendable

Require `ThreadSafeBox.T` to be Sendable

Author: ahoppen

Sources/SKSupport/AsyncUtils.swift

@@ -98,7 +98,7 @@ public extension Task where Failure == Never {
 ///
 /// If the task executing `withCancellableCheckedThrowingContinuation` gets
 /// cancelled, `cancel` is invoked with the handle that `operation` provided.
-public func withCancellableCheckedThrowingContinuation<Handle, Result>(
+public func withCancellableCheckedThrowingContinuation<Handle: Sendable, Result>(
   _ operation: (_ continuation: CheckedContinuation<Result, any Error>) -> Handle,
   cancel: @Sendable (Handle) -> Void
 ) async throws -> Result {

Sources/SKSupport/ThreadSafeBox.swift

@@ -24,7 +24,7 @@ extension NSLock {
 /// A thread safe container that contains a value of type `T`.
 ///
 /// - Note: Unchecked sendable conformance because value is guarded by a lock.
-public class ThreadSafeBox<T>: @unchecked Sendable {
+public class ThreadSafeBox<T: Sendable>: @unchecked Sendable {
   /// Lock guarding `_value`.
   private let lock = NSLock()
 
@@ -41,6 +41,11 @@ public class ThreadSafeBox<T>: @unchecked Sendable {
         _value = newValue
       }
     }
+    _modify {
+      lock.lock()
+      defer { lock.unlock() }
+      yield &_value
+    }
   }
 
   public init(initialValue: T) {

Sources/SKTestSupport/TestSourceKitLSPClient.swift

@@ -38,7 +38,7 @@ fileprivate struct NotificationTimeoutError: Error, CustomStringConvertible {
 /// that the server sends to the client.
 public final class TestSourceKitLSPClient: MessageHandler {
   /// A function that takes a request and returns the request's response.
-  public typealias RequestHandler<Request: RequestType> = (Request) -> Request.Response
+  public typealias RequestHandler<Request: RequestType> = @Sendable (Request) -> Request.Response
 
   /// The ID that should be assigned to the next request sent to the `server`.
   /// `nonisolated(unsafe)` is fine because `nextRequestID` is atomic.
@@ -70,7 +70,7 @@ public final class TestSourceKitLSPClient: MessageHandler {
   ///
   /// `isOneShort` if the request handler should only serve a single request and should be removed from
   /// `requestHandlers` after it has been called.
-  private nonisolated(unsafe) var requestHandlers: ThreadSafeBox<[(requestHandler: Any, isOneShot: Bool)]> =
+  private nonisolated(unsafe) var requestHandlers: ThreadSafeBox<[(requestHandler: Sendable, isOneShot: Bool)]> =
     ThreadSafeBox(initialValue: [])
 
   /// A closure that is called when the `TestSourceKitLSPClient` is destructed.

Sources/SourceKitD/SourceKitD.swift

@@ -15,6 +15,12 @@ import Dispatch
 import Foundation
 import SKSupport
 
+#if compiler(>=6)
+extension sourcekitd_api_request_handle_t: @retroactive @unchecked Sendable {}
+#else
+extension sourcekitd_api_request_handle_t: @unchecked Sendable {}
+#endif
+
 /// Access to sourcekitd API, taking care of initialization, shutdown, and notification handler
 /// multiplexing.
 ///