Change executionStateChangedCallback to be synchronous

There was no need for this function to be `async` and it’s easier to reason about the code if there are no suspensions here.

Author: ahoppen

Sources/SKCore/TaskScheduler.swift

@@ -179,12 +179,12 @@ public actor QueuedTask<TaskDescription: TaskDescriptionProtocol> {
 
   /// A callback that will be called when the task starts executing, is cancelled to be rescheduled, or when it finishes
   /// execution.
-  private let executionStateChangedCallback: (@Sendable (QueuedTask, TaskExecutionState) async -> Void)?
+  private let executionStateChangedCallback: (@Sendable (QueuedTask, TaskExecutionState) -> Void)?
 
   init(
     priority: TaskPriority,
     description: TaskDescription,
-    executionStateChangedCallback: (@Sendable (QueuedTask, TaskExecutionState) async -> Void)?
+    executionStateChangedCallback: (@Sendable (QueuedTask, TaskExecutionState) -> Void)?
   ) async {
     self._priority = AtomicUInt8(initialValue: priority.rawValue)
     self.description = description
@@ -238,7 +238,7 @@ public actor QueuedTask<TaskDescription: TaskDescriptionProtocol> {
     executionTask = task
     executionTaskCreatedContinuation.yield(task)
     _isExecuting.value = true
-    await executionStateChangedCallback?(self, .executing)
+    executionStateChangedCallback?(self, .executing)
     return await task.value
   }
 
@@ -247,11 +247,11 @@ public actor QueuedTask<TaskDescription: TaskDescriptionProtocol> {
     self.executionTask = nil
     _isExecuting.value = false
     if Task.isCancelled && self.cancelledToBeRescheduled {
-      await executionStateChangedCallback?(self, .cancelledToBeRescheduled)
+      executionStateChangedCallback?(self, .cancelledToBeRescheduled)
       self.cancelledToBeRescheduled = false
       return ExecutionTaskFinishStatus.cancelledToBeRescheduled
     } else {
-      await executionStateChangedCallback?(self, .finished)
+      executionStateChangedCallback?(self, .finished)
       return ExecutionTaskFinishStatus.terminated
     }
   }
@@ -352,7 +352,7 @@ public actor TaskScheduler<TaskDescription: TaskDescriptionProtocol> {
     priority: TaskPriority? = nil,
     _ taskDescription: TaskDescription,
     @_inheritActorContext executionStateChangedCallback: (
-      @Sendable (QueuedTask<TaskDescription>, TaskExecutionState) async -> Void
+      @Sendable (QueuedTask<TaskDescription>, TaskExecutionState) -> Void
     )? = nil
   ) async -> QueuedTask<TaskDescription> {
     let queuedTask = await QueuedTask(

Tests/SourceKitLSPTests/MainFilesProviderTests.swift

@@ -212,7 +212,7 @@ final class MainFilesProviderTests: XCTestCase {
       DidChangeWatchedFilesNotification(changes: [FileEvent(uri: fancyLibraryUri, type: .changed)])
     )
 
-    // 'MyFancyLibrary.c' now also includes 'shared.h'. Since it lexicographically preceeds MyLibrary, we should use its
+    // 'MyFancyLibrary.c' now also includes 'shared.h'. Since it lexicographically precedes MyLibrary, we should use its
     // build settings.
     let postEditDiags = try await project.testClient.nextDiagnosticsNotification()
     XCTAssertEqual(postEditDiags.diagnostics.count, 1)