Use SourceKit's not_recommended field to populate deprecated in Code completion responses

Author: ahoppen

Sources/SourceKit/sourcekitd/SwiftLanguageServer.swift

@@ -406,6 +406,9 @@ extension SwiftLanguageServer {
             textEdit = nil
           }
 
+          // Map SourceKit's not_recommended field to LSP's deprecated
+          let notRecommended = (value[self.keys.not_recommended] as Int?).map({ $0 != 0 })
+
           let kind: sourcekitd_uid_t? = value[self.keys.kind]
           result.items.append(CompletionItem(
             label: name,
@@ -416,7 +419,7 @@ extension SwiftLanguageServer {
             insertText: text,
             insertTextFormat: isInsertTextSnippet ? .snippet : .plain,
             kind: kind?.asCompletionItemKind(self.values) ?? .value,
-            deprecated: nil
+            deprecated: notRecommended ?? false
           ))
 
           return true

Tests/SourceKitTests/SourceKitTests.swift

@@ -160,7 +160,7 @@ final class SKTests: XCTestCase {
         insertText: "method(a: )",
         insertTextFormat: .plain,
         kind: .method,
-        deprecated: nil),
+        deprecated: false),
       CompletionItem(
         label: "self",
         detail: "A",
@@ -170,7 +170,7 @@ final class SKTests: XCTestCase {
         insertText: "self",
         insertTextFormat: .plain,
         kind: .keyword,
-        deprecated: nil),
+        deprecated: false),
     ]))
   }
 }

Tests/SourceKitTests/SwiftPMIntegration.swift

@@ -41,7 +41,7 @@ final class SwiftPMIntegrationTests: XCTestCase {
         insertText: "foo()",
         insertTextFormat: .plain,
         kind: .method,
-        deprecated: nil),
+        deprecated: false),
       CompletionItem(
         label: "self",
         detail: "Lib",
@@ -51,7 +51,7 @@ final class SwiftPMIntegrationTests: XCTestCase {
         insertText: "self",
         insertTextFormat: .plain,
         kind: .keyword,
-        deprecated: nil),
+        deprecated: false),
     ]))
   }
 }